This is an automated email from the ASF dual-hosted git repository.
rzo1 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-stormcrawler.git
The following commit(s) were added to refs/heads/main by this push:
new a7ad1bb1 Fix #1163 - Change the GitHub templates for PRs to be more
ASF specific (#1185)
a7ad1bb1 is described below
commit a7ad1bb1996bd82050c2709cd61f97b96ae1795a
Author: Richard Zowalla <[email protected]>
AuthorDate: Thu Apr 4 10:39:22 2024 +0200
Fix #1163 - Change the GitHub templates for PRs to be more ASF specific
(#1185)
---
.github/PULL_REQUEST_TEMPLATE.md | 64 +++++++++++-----------------------------
1 file changed, 17 insertions(+), 47 deletions(-)
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 8fb253c1..8c0e54c9 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,57 +1,27 @@
-Thanks for contributing to StormCrawler, your efforts are appreciated!
+Thank you for contributing to Apache StormCrawler.
-Developer Certificate of Origin
-===============================
+In order to streamline the review of the contribution we ask you
+to ensure the following steps have been taken:
-By contributing to StormCrawler, you accept and agree to the following terms
and conditions (the *Developer Certificate of Origin*) for your present and
future contributions submitted to StormCrawler.
-Please refer to the *Developer Certificate of Origin* section in
[`CONTRIBUTING.md`](CONTRIBUTING.md) for details.
+### For all changes:
+- [ ] Is there a issue associated with this PR? Is it referenced in the commit
message?
-```
-Developer Certificate of Origin
-Version 1.1
+- [ ] Does your PR title start with `#XXXX` where `XXXX` is the issue number
you are trying to resolve?
-Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
-1 Letterman Drive
-Suite D4700
-San Francisco, CA, 94129
+- [ ] Has your PR been rebased against the latest commit within the target
branch (typically main)?
-Everyone is permitted to copy and distribute verbatim copies of this
-license document, but changing it is not allowed.
+- [ ] Is your initial contribution a single, squashed commit?
+- [ ] Is the code properly formatted with `mvn git-code-format:format-code
-Dgcf.globPattern=**/*`?
-Developer's Certificate of Origin 1.1
+### For code changes:
-By making a contribution to this project, I certify that:
+- [ ] Have you ensured that the full suite of tests is executed via `mvn clean
verify`?
+- [ ] Have you written or updated unit tests to verify your changes?
+- [ ] If adding new dependencies to the code, are these dependencies licensed
in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
+- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file?
+- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file?
-(a) The contribution was created in whole or in part by me and I
- have the right to submit it under the open source license
- indicated in the file; or
-
-(b) The contribution is based upon previous work that, to the best
- of my knowledge, is covered under an appropriate open source
- license and I have the right under that license to submit that
- work with modifications, whether created in whole or in part
- by me, under the same open source license (unless I am
- permitted to submit under a different license), as indicated
- in the file; or
-
-(c) The contribution was provided directly to me by some other
- person who certified (a), (b) or (c) and I have not modified
- it.
-
-(d) I understand and agree that this project and the contribution
- are public and that a record of the contribution (including all
- personal information I submit with it, including my sign-off) is
- maintained indefinitely and may be redistributed consistent with
- this project or the open source license(s) involved.
-```
-
-Before opening a PR, please check that:
-
-* You've squashed your commits into a single one
-* You've described what the PR does or at least point to a related issue
-* You've signed-ff your commits with 'git commit -s'
-* The code is properly formatted with 'mvn git-code-format:format-code
-Dgcf.globPattern=**/*'
-
-Thanks!
+### Note:
+Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
