This is an automated email from the ASF dual-hosted git repository.
rzo1 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/stormcrawler.git
The following commit(s) were added to refs/heads/main by this push:
new bb71b720 Fix NOP logger configuration in core/pom.xml (#1628)
bb71b720 is described below
commit bb71b7201f218b0153611172f2773fd0644aad50
Author: Hrishikesh Uchake <135912491+hrishikeshuch...@users.noreply.github.com>
AuthorDate: Thu Aug 14 02:31:24 2025 -0500
Fix NOP logger configuration in core/pom.xml (#1628)
* Fix NOP logger configuration in core/pom.xml
* Addressing reviewer feedback:
- Added slf4j-simple.version property to root pom.xml
- Added slf4j-simple to dependencyManagement in root pom.xml
- Remove hardcoded version from core/pom.xml
- Added slf4j-simple dependency to external modules (opensearch, solr,
urlfrontier)
- Added exclusions to storm-client to eliminate multiple SLF4J providers
warnings
- Resolves both NOP logger issue #1578 and multiple SLF4J providers conflict
---
core/pom.xml | 6 ++++++
external/opensearch/pom.xml | 6 ++++++
external/solr/pom.xml | 6 ++++++
external/urlfrontier/pom.xml | 6 ++++++
pom.xml | 20 ++++++++++++++++++++
5 files changed, 44 insertions(+)
diff --git a/core/pom.xml b/core/pom.xml
index d35347c8..63ae4d2b 100644
--- a/core/pom.xml
+++ b/core/pom.xml
@@ -110,6 +110,12 @@ under the License.
<artifactId>junit-jupiter</artifactId>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-simple</artifactId>
+ <scope>test</scope>
+ </dependency>
<dependency>
<groupId>org.apache.storm</groupId>
diff --git a/external/opensearch/pom.xml b/external/opensearch/pom.xml
index c6344dc2..dc928d34 100644
--- a/external/opensearch/pom.xml
+++ b/external/opensearch/pom.xml
@@ -105,5 +105,11 @@ under the License.
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-simple</artifactId>
+ <scope>test</scope>
+ </dependency>
+
</dependencies>
</project>
diff --git a/external/solr/pom.xml b/external/solr/pom.xml
index feed48fe..89fd50a7 100644
--- a/external/solr/pom.xml
+++ b/external/solr/pom.xml
@@ -54,6 +54,12 @@ under the License.
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-simple</artifactId>
+ <scope>test</scope>
+ </dependency>
+
<dependency>
<groupId>org.apache.stormcrawler</groupId>
<artifactId>stormcrawler-core</artifactId>
diff --git a/external/urlfrontier/pom.xml b/external/urlfrontier/pom.xml
index c0b5012b..840a8e29 100644
--- a/external/urlfrontier/pom.xml
+++ b/external/urlfrontier/pom.xml
@@ -95,6 +95,12 @@ under the License.
<artifactId>junit-jupiter</artifactId>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-simple</artifactId>
+ <scope>test</scope>
+ </dependency>
</dependencies>
</project>
diff --git a/pom.xml b/pom.xml
index 26664c13..36a79bd4 100644
--- a/pom.xml
+++ b/pom.xml
@@ -70,6 +70,7 @@ under the License.
<jackson.version>2.18.1</jackson.version>
<tika.version>3.2.2</tika.version>
<mockito.version>5.18.0</mockito.version>
+ <slf4j-simple.version>2.0.17</slf4j-simple.version>
<jetbrains.annotations.version>26.0.2</jetbrains.annotations.version>
<commons.io.version>2.17.0</commons.io.version>
<git-code-format-maven-plugin.version>5.3</git-code-format-maven-plugin.version>
@@ -572,12 +573,31 @@ under the License.
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-simple</artifactId>
+ <version>${slf4j-simple.version}</version>
+ <scope>test</scope>
+ </dependency>
+
<dependency>
<groupId>org.apache.storm</groupId>
<artifactId>storm-client</artifactId>
<version>${storm-client.version}</version>
<!-- keep storm out of the
jar-with-dependencies -->
<scope>provided</scope>
+ <exclusions>
+ <!-- Exclude Log4j SLF4J implementation
to avoid conflicts with slf4j-simple in tests -->
+ <exclusion>
+
<groupId>org.apache.logging.log4j</groupId>
+
<artifactId>log4j-slf4j2-impl</artifactId>
+ </exclusion>
+ <!-- Exclude Log4j over SLF4J bridge as
we use slf4j-simple for tests -->
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+
<artifactId>log4j-over-slf4j</artifactId>
+ </exclusion>
+ </exclusions>
</dependency>
<dependency>
