This is an automated email from the ASF dual-hosted git repository. rzo1 pushed a commit to branch make-jdbc-driver-optional in repository https://gitbox.apache.org/repos/asf/stormcrawler.git
commit 36aa877f45aa1c0e290d09443e4a73db7f484d4e Author: Richard Zowalla <[email protected]> AuthorDate: Mon Jan 12 13:10:57 2026 +0100 JDBC driver should be optional and not supplied to be vendor agnostic. --- external/sql/README.md | 10 +++++----- external/sql/pom.xml | 2 ++ pom.xml | 6 ------ 3 files changed, 7 insertions(+), 11 deletions(-) diff --git a/external/sql/README.md b/external/sql/README.md index f5400731..c6de8068 100644 --- a/external/sql/README.md +++ b/external/sql/README.md @@ -7,11 +7,11 @@ The [tableCreation.script](https://github.com/apache/stormcrawler/blob/main/exte Check that you have specified a configuration file such as [sql-conf.yaml](https://github.com/apache/stormcrawler/blob/master/external/sql/sql-conf.yaml) and have a Java driver in the dependencies of your POM ``` - <dependency> - <groupId>mysql</groupId> - <artifactId>mysql-connector-java</artifactId> - <version>5.1.31</version> - </dependency> + <dependency> + <groupId>com.mysql</groupId> + <artifactId>mysql-connector-j</artifactId> + <scope>provided</scope> + </dependency> ``` You can either inject the seeds directly as done in the tutorial or reuse the injection topology from the elasticsearch module and specify the statusupdaterbolt from the mysql module instead. Another approach could be to simply to add a MemorySpout to the topology alongside the SQLSpout. diff --git a/external/sql/pom.xml b/external/sql/pom.xml index 2b0ece44..7882c37d 100644 --- a/external/sql/pom.xml +++ b/external/sql/pom.xml @@ -51,6 +51,8 @@ under the License. <dependency> <groupId>com.mysql</groupId> <artifactId>mysql-connector-j</artifactId> + <version>${mysql-connector-j}</version> + <scope>provided</scope> </dependency> <dependency> <groupId>org.apache.stormcrawler</groupId> diff --git a/pom.xml b/pom.xml index 2ad34c1d..5e85261e 100644 --- a/pom.xml +++ b/pom.xml @@ -674,12 +674,6 @@ under the License. <version>${commons.codec.version}</version> </dependency> - <dependency> - <groupId>com.mysql</groupId> - <artifactId>mysql-connector-j</artifactId> - <version>${mysql-connector-j}</version> - </dependency> - </dependencies> </dependencyManagement>
