This is an automated email from the ASF dual-hosted git repository. sigee pushed a commit to branch fix-checkstyle-issues in repository https://gitbox.apache.org/repos/asf/stormcrawler.git
commit bf48a965557c6943ecf9cd5a8086508eeb0f9b08 Author: Dávid Szigecsán <[email protected]> AuthorDate: Sun Mar 1 15:23:32 2026 +0100 Make checkstyle rules severity to error, except the not yet fixed ones --- checkstyle.xml | 46 ++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 38 insertions(+), 8 deletions(-) diff --git a/checkstyle.xml b/checkstyle.xml index 99e4ff66..a10df412 100644 --- a/checkstyle.xml +++ b/checkstyle.xml @@ -27,7 +27,7 @@ under the License. <property name="charset" value="UTF-8"/> - <property name="severity" value="warning"/> + <property name="severity" value="error"/> <property name="fileExtensions" value="java, properties, xml"/> <!-- Excludes all 'module-info.java' files --> @@ -64,6 +64,7 @@ under the License. <property name="max" value="100"/> <property name="ignorePattern" value="^package.*|^import.*|href\s*=\s*"[^"]*"|http://|https://|ftp://"/> + <property name="severity" value="warning"/> </module> <!-- Suppression to prevent LineLength Check from flagging lines in Text-blocks --> <module name="SuppressWithPlainTextCommentFilter"> @@ -94,7 +95,9 @@ under the License. <property name="allowNonPrintableEscapes" value="true"/> </module> <module name="AvoidStarImport"/> - <module name="OneTopLevelClass"/> + <module name="OneTopLevelClass"> + <property name="severity" value="warning"/> + </module> <module name="NoLineWrap"> <property name="tokens" value="PACKAGE_DEF, IMPORT, STATIC_IMPORT"/> </module> @@ -251,6 +254,7 @@ under the License. <property name="tokens" value="CLASS_DEF"/> <message key="name.invalidPattern" value="Type name ''{0}'' must match pattern ''{1}''."/> + <property name="severity" value="warning"/> </module> <module name="TypeName"> <property name="tokens" value="INTERFACE_DEF, ENUM_DEF, @@ -263,16 +267,19 @@ under the License. value="^(?![a-z]$)(?![a-z][A-Z])[a-z][a-zA-Z0-9]*(?:_[0-9]+)*$"/> <message key="name.invalidPattern" value="Member name ''{0}'' must match pattern ''{1}''."/> + <property name="severity" value="warning"/> </module> <module name="ParameterName"> <property name="format" value="^[a-z]([a-z0-9][a-zA-Z0-9]*)?$"/> <message key="name.invalidPattern" value="Parameter name ''{0}'' must match pattern ''{1}''."/> + <property name="severity" value="warning"/> </module> <module name="LambdaParameterName"> <property name="format" value="^[a-z]([a-z0-9][a-zA-Z0-9]*)?$"/> <message key="name.invalidPattern" value="Lambda parameter name ''{0}'' must match pattern ''{1}''."/> + <property name="severity" value="warning"/> </module> <module name="CatchParameterName"> <property name="format" value="^[a-z]([a-z0-9][a-zA-Z0-9]*)?$"/> @@ -283,6 +290,7 @@ under the License. <property name="format" value="^[a-z]([a-z0-9][a-zA-Z0-9]*)?$"/> <message key="name.invalidPattern" value="Local variable name ''{0}'' must match pattern ''{1}''."/> + <property name="severity" value="warning"/> </module> <module name="PatternVariableName"> <property name="format" value="^[a-z]([a-z0-9][a-zA-Z0-9]*)?$"/> @@ -341,11 +349,14 @@ under the License. value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, ANNOTATION_DEF, ANNOTATION_FIELD_DEF, PARAMETER_DEF, VARIABLE_DEF, METHOD_DEF, PATTERN_VARIABLE_DEF, RECORD_DEF, RECORD_COMPONENT_DEF"/> + <property name="severity" value="warning"/> </module> <module name="NoWhitespaceBeforeCaseDefaultColon"/> <module name="OverloadMethodsDeclarationOrder"/> <module name="ConstructorsDeclarationGrouping"/> - <module name="VariableDeclarationUsageDistance"/> + <module name="VariableDeclarationUsageDistance"> + <property name="severity" value="warning"/> + </module> <module name="CustomImportOrder"> <property name="sortImportsInGroupAlphabetically" value="true"/> <property name="separateLineBetweenGroups" value="true"/> @@ -376,6 +387,7 @@ under the License. LITERAL_SWITCH, LITERAL_SYNCHRONIZED, LITERAL_WHILE, METHOD_CALL, METHOD_DEF, QUESTION, RESOURCE_SPECIFICATION, SUPER_CTOR_CALL, LAMBDA, RECORD_DEF, RECORD_PATTERN_DEF"/> + <property name="severity" value="warning"/> </module> <module name="OperatorWrap"> <property name="option" value="NL"/> @@ -395,21 +407,32 @@ under the License. <property name="tokens" value="VARIABLE_DEF"/> <property name="allowSamelineMultipleAnnotations" value="true"/> </module> - <module name="NonEmptyAtclauseDescription"/> - <module name="InvalidJavadocPosition"/> - <module name="JavadocTagContinuationIndentation"/> + <module name="NonEmptyAtclauseDescription"> + <property name="severity" value="warning"/> + </module> + <module name="InvalidJavadocPosition"> + <property name="severity" value="warning"/> + </module> + <module name="JavadocTagContinuationIndentation"> + <property name="severity" value="warning"/> + </module> <module name="SummaryJavadoc"> <property name="forbiddenSummaryFragments" value="^@return the *|^This method returns |^A [{]@code [a-zA-Z0-9]+[}]( is a )"/> + <property name="severity" value="warning"/> </module> <module name="JavadocParagraph"> <property name="allowNewlineParagraph" value="false"/> + <property name="severity" value="warning"/> + </module> + <module name="RequireEmptyLineBeforeBlockTagGroup"> + <property name="severity" value="warning"/> </module> - <module name="RequireEmptyLineBeforeBlockTagGroup"/> <module name="AtclauseOrder"> <property name="tagOrder" value="@param, @return, @throws, @deprecated"/> <property name="target" value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/> + <property name="severity" value="warning"/> </module> <module name="JavadocMethod"> <property name="accessModifiers" value="public"/> @@ -424,6 +447,7 @@ under the License. <property name="allowedAnnotations" value="Override, Test"/> <property name="tokens" value="METHOD_DEF, CTOR_DEF, ANNOTATION_FIELD_DEF, COMPACT_CTOR_DEF"/> + <property name="severity" value="warning"/> </module> <module name="SuppressionXpathSingleFilter"> <property name="checks" value="MissingJavadocMethod"/> @@ -439,12 +463,14 @@ under the License. value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, RECORD_DEF, ANNOTATION_DEF"/> <property name="excludeScope" value="nothing"/> + <property name="severity" value="warning"/> </module> <module name="MethodName"> <property name="format" value="^(?![a-z]$)(?![a-z][A-Z])[a-z][a-z0-9]*(?:[A-Z][a-z0-9]*)*(?:_[0-9]+)*$"/> <message key="name.invalidPattern" value="Method name ''{0}'' must match pattern ''{1}''."/> + <property name="severity" value="warning"/> </module> <module name="SuppressionXpathSingleFilter"> <property name="checks" value="MethodName"/> @@ -453,14 +479,18 @@ under the License. ]/IDENT"/> <property name="message" value="'[a-z][a-z0-9][a-zA-Z0-9]*(?:_[a-z][a-z0-9][a-zA-Z0-9]*)*'"/> </module> - <module name="SingleLineJavadoc"/> + <module name="SingleLineJavadoc"> + <property name="severity" value="warning"/> + </module> <module name="TodoComment"> <property name="format" value="^[ \t]*(?!TODO:)(?i:TODO)\b:?"/> <message key="todo.match" value="''TODO:'' must be written in all caps and followed by a colon."/> + <property name="severity" value="warning"/> </module> <module name="EmptyCatchBlock"> <property name="commentFormat" value="\w+"/> + <property name="severity" value="warning"/> </module> <module name="CommentsIndentation"> <property name="tokens" value="SINGLE_LINE_COMMENT, BLOCK_COMMENT_BEGIN"/>
