Code cleanup : unnecessary TODOs
Project: http://git-wip-us.apache.org/repos/asf/stratos/repo Commit: http://git-wip-us.apache.org/repos/asf/stratos/commit/850fd055 Tree: http://git-wip-us.apache.org/repos/asf/stratos/tree/850fd055 Diff: http://git-wip-us.apache.org/repos/asf/stratos/diff/850fd055 Branch: refs/heads/master Commit: 850fd055d2277604448d4b0d2e9218a25b3a0510 Parents: 2d9f1ec Author: Chamila de Alwis <[email protected]> Authored: Wed Oct 1 16:42:31 2014 +0530 Committer: Chamila de Alwis <[email protected]> Committed: Thu Oct 9 15:40:34 2014 +0530 ---------------------------------------------------------------------- .../modules/extensions/defaultextensionhandler.py | 2 +- .../healthstatspublisher/abstracthealthstatisticspublisher.py | 2 +- .../cartridge-agent/modules/healthstatspublisher/healthstats.py | 3 +-- .../modules/publisher/cartridgeagentpublisher.py | 2 +- .../cartridge-agent/modules/subscriber/eventsubscriber.py | 2 +- .../cartridge-agent/modules/tenant/tenantcontext.py | 2 +- .../cartridge-agent/modules/topology/topologycontext.py | 5 ----- 7 files changed, 6 insertions(+), 12 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/stratos/blob/850fd055/tools/python-cartridge-agent/cartridge-agent/modules/extensions/defaultextensionhandler.py ---------------------------------------------------------------------- diff --git a/tools/python-cartridge-agent/cartridge-agent/modules/extensions/defaultextensionhandler.py b/tools/python-cartridge-agent/cartridge-agent/modules/extensions/defaultextensionhandler.py index 6d49d8f..2687687 100644 --- a/tools/python-cartridge-agent/cartridge-agent/modules/extensions/defaultextensionhandler.py +++ b/tools/python-cartridge-agent/cartridge-agent/modules/extensions/defaultextensionhandler.py @@ -14,7 +14,7 @@ from abstractextensionhandler import AbstractExtensionHandler class DefaultExtensionHandler(AbstractExtensionHandler): """ - TODO : Provide abstraction + Default implementation of the AbstractExtensionHandler """ log = None http://git-wip-us.apache.org/repos/asf/stratos/blob/850fd055/tools/python-cartridge-agent/cartridge-agent/modules/healthstatspublisher/abstracthealthstatisticspublisher.py ---------------------------------------------------------------------- diff --git a/tools/python-cartridge-agent/cartridge-agent/modules/healthstatspublisher/abstracthealthstatisticspublisher.py b/tools/python-cartridge-agent/cartridge-agent/modules/healthstatspublisher/abstracthealthstatisticspublisher.py index e2121b6..eaf8546 100644 --- a/tools/python-cartridge-agent/cartridge-agent/modules/healthstatspublisher/abstracthealthstatisticspublisher.py +++ b/tools/python-cartridge-agent/cartridge-agent/modules/healthstatspublisher/abstracthealthstatisticspublisher.py @@ -1,6 +1,6 @@ class AbstractHealthStatisticsReader: """ - TODO: + Abstract class to implement to create a custom health stat reader """ def stat_cartridge_health(self): http://git-wip-us.apache.org/repos/asf/stratos/blob/850fd055/tools/python-cartridge-agent/cartridge-agent/modules/healthstatspublisher/healthstats.py ---------------------------------------------------------------------- diff --git a/tools/python-cartridge-agent/cartridge-agent/modules/healthstatspublisher/healthstats.py b/tools/python-cartridge-agent/cartridge-agent/modules/healthstatspublisher/healthstats.py index d631b82..953c0fc 100644 --- a/tools/python-cartridge-agent/cartridge-agent/modules/healthstatspublisher/healthstats.py +++ b/tools/python-cartridge-agent/cartridge-agent/modules/healthstatspublisher/healthstats.py @@ -150,8 +150,7 @@ class DefaultHealthStatisticsReader(AbstractHealthStatisticsReader): class CEPPublisherConfiguration: """ - A singleton implementation to access configuration information for data publishing to BAM/CEP - TODO: perfect singleton impl ex: Borg + TODO: Extract common functionality """ __instance = None http://git-wip-us.apache.org/repos/asf/stratos/blob/850fd055/tools/python-cartridge-agent/cartridge-agent/modules/publisher/cartridgeagentpublisher.py ---------------------------------------------------------------------- diff --git a/tools/python-cartridge-agent/cartridge-agent/modules/publisher/cartridgeagentpublisher.py b/tools/python-cartridge-agent/cartridge-agent/modules/publisher/cartridgeagentpublisher.py index fcbe5f1..0427e46 100644 --- a/tools/python-cartridge-agent/cartridge-agent/modules/publisher/cartridgeagentpublisher.py +++ b/tools/python-cartridge-agent/cartridge-agent/modules/publisher/cartridgeagentpublisher.py @@ -136,7 +136,7 @@ def get_publisher(topic): class EventPublisher: """ - TODO: provide abstraction + Handles publishing events to topics to the provided message broker """ def __init__(self, topic): self.__topic = topic http://git-wip-us.apache.org/repos/asf/stratos/blob/850fd055/tools/python-cartridge-agent/cartridge-agent/modules/subscriber/eventsubscriber.py ---------------------------------------------------------------------- diff --git a/tools/python-cartridge-agent/cartridge-agent/modules/subscriber/eventsubscriber.py b/tools/python-cartridge-agent/cartridge-agent/modules/subscriber/eventsubscriber.py index 8d418fa..ad32180 100644 --- a/tools/python-cartridge-agent/cartridge-agent/modules/subscriber/eventsubscriber.py +++ b/tools/python-cartridge-agent/cartridge-agent/modules/subscriber/eventsubscriber.py @@ -44,7 +44,7 @@ class EventSubscriber(threading.Thread): """ Adds an event handler function mapped to the provided event. :param str event: Name of the event to attach the provided handler - :param handler: TODO + :param (str)->void handler: The handler function :return: void :rtype: void """ http://git-wip-us.apache.org/repos/asf/stratos/blob/850fd055/tools/python-cartridge-agent/cartridge-agent/modules/tenant/tenantcontext.py ---------------------------------------------------------------------- diff --git a/tools/python-cartridge-agent/cartridge-agent/modules/tenant/tenantcontext.py b/tools/python-cartridge-agent/cartridge-agent/modules/tenant/tenantcontext.py index 90c9f0b..43bea0b 100644 --- a/tools/python-cartridge-agent/cartridge-agent/modules/tenant/tenantcontext.py +++ b/tools/python-cartridge-agent/cartridge-agent/modules/tenant/tenantcontext.py @@ -105,7 +105,7 @@ class Subscription: class SubscriptionDomain: """ - TODO + Represents a Subscription Domain """ def __init__(self, domain_name, application_context): http://git-wip-us.apache.org/repos/asf/stratos/blob/850fd055/tools/python-cartridge-agent/cartridge-agent/modules/topology/topologycontext.py ---------------------------------------------------------------------- diff --git a/tools/python-cartridge-agent/cartridge-agent/modules/topology/topologycontext.py b/tools/python-cartridge-agent/cartridge-agent/modules/topology/topologycontext.py index 564b959..5d92306 100644 --- a/tools/python-cartridge-agent/cartridge-agent/modules/topology/topologycontext.py +++ b/tools/python-cartridge-agent/cartridge-agent/modules/topology/topologycontext.py @@ -406,11 +406,6 @@ class TopologyContext: TopologyContext.topology = Topology() return TopologyContext.topology - # @staticmethod - # def update(topology): - # TopologyContext.topology = topology - # #TODO: persist in registry - @staticmethod def update(topology): TopologyContext.topology = topology \ No newline at end of file
