Improve error messages in rest API

Project: http://git-wip-us.apache.org/repos/asf/stratos/repo
Commit: http://git-wip-us.apache.org/repos/asf/stratos/commit/3ae231b6
Tree: http://git-wip-us.apache.org/repos/asf/stratos/tree/3ae231b6
Diff: http://git-wip-us.apache.org/repos/asf/stratos/diff/3ae231b6

Branch: refs/heads/master
Commit: 3ae231b66364f206644af8a0209cfcfc78335e86
Parents: 5f94f7e
Author: Lahiru Sandaruwan <[email protected]>
Authored: Thu Apr 30 11:35:38 2015 +0530
Committer: Lahiru Sandaruwan <[email protected]>
Committed: Thu Apr 30 11:35:38 2015 +0530

----------------------------------------------------------------------
 .../org/apache/stratos/rest/endpoint/api/StratosApiV41.java | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/stratos/blob/3ae231b6/components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41.java
----------------------------------------------------------------------
diff --git 
a/components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41.java
 
b/components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41.java
index a1a1505..40fb386 100644
--- 
a/components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41.java
+++ 
b/components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41.java
@@ -683,7 +683,8 @@ public class StratosApiV41 extends AbstractApi {
     public Response getApplications() throws RestAPIException {
         List<ApplicationBean> applicationDefinitions = 
StratosApiV41Utils.getApplications();
         if (applicationDefinitions == null || 
applicationDefinitions.isEmpty()) {
-            return Response.status(Response.Status.NOT_FOUND).build();
+            return Response.status(Response.Status.NOT_FOUND).entity(new 
ErrorResponseBean(
+                    Response.Status.NOT_FOUND.getStatusCode(), "No 
applications found")).build();
         }
 
         ApplicationBean[] applicationDefinitionsArray = applicationDefinitions
@@ -707,7 +708,8 @@ public class StratosApiV41 extends AbstractApi {
             @PathParam("applicationId") String applicationId) throws 
RestAPIException {
         ApplicationBean applicationDefinition = 
StratosApiV41Utils.getApplication(applicationId);
         if (applicationDefinition == null) {
-            return Response.status(Response.Status.NOT_FOUND).build();
+            return Response.status(Response.Status.NOT_FOUND).entity(new 
ErrorResponseBean(
+                    Response.Status.NOT_FOUND.getStatusCode(), "Application 
not found")).build();
         }
         return Response.ok(applicationDefinition).build();
     }
@@ -734,7 +736,8 @@ public class StratosApiV41 extends AbstractApi {
                     String.format("Application deployed successfully: 
[application] %s", applicationId))).build();
         } catch (ApplicationAlreadyDeployedException e) {
 
-            return Response.status(Response.Status.CONFLICT).build();
+            return Response.status(Response.Status.CONFLICT).entity(new 
ErrorResponseBean(
+                    Response.Status.CONFLICT.getStatusCode(), "Application 
policy already deployed")).build();
         } catch (RestAPIException e) {
 
             throw e;

Reply via email to