[incubator-streampark] branch issue-2869 updated: minor improvement

[benjobs]

This is an automated email from the ASF dual-hosted git repository.

benjobs pushed a commit to branch issue-2869
in repository https://gitbox.apache.org/repos/asf/incubator-streampark.git


The following commit(s) were added to refs/heads/issue-2869 by this push:
     new e0d3aaff4 minor improvement
e0d3aaff4 is described below

commit e0d3aaff436c6044326d288ae91ea774b4466acb
Author: benjobs <benj...@apache.org>
AuthorDate: Sat Aug 5 17:04:22 2023 +0800

    minor improvement
---
 .../streampark/common/util/PropertiesUtilsTestCase.scala    | 13 +++----------
 .../streampark/flink/client/trait/FlinkClientTrait.scala    | 13 +++----------
 2 files changed, 6 insertions(+), 20 deletions(-)

diff --git 
a/streampark-common/src/test/scala/org/apache/streampark/common/util/PropertiesUtilsTestCase.scala
 
b/streampark-common/src/test/scala/org/apache/streampark/common/util/PropertiesUtilsTestCase.scala
index 593d141fd..88f7b3575 100644
--- 
a/streampark-common/src/test/scala/org/apache/streampark/common/util/PropertiesUtilsTestCase.scala
+++ 
b/streampark-common/src/test/scala/org/apache/streampark/common/util/PropertiesUtilsTestCase.scala
@@ -57,6 +57,7 @@ class PropertiesUtilsTestCase {
 
           val next = index + 1
           val elem = array(index).trim
+          val until = if (elem.endsWith(multiChar)) 1 else 0
 
           if (elem.isEmpty) {
             processElement(next, multi = false)
@@ -73,18 +74,10 @@ class PropertiesUtilsTestCase {
               }
             } else {
               if (elem.startsWith(multiChar)) {
-                if (elem.endsWith(multiChar)) {
-                  tempBuffer += elem.drop(1).dropRight(1)
-                } else {
-                  tempBuffer += elem.drop(1)
-                }
+                tempBuffer += elem.drop(1).dropRight(until)
                 processElement(next, multi = true)
               } else {
-                if (elem.endsWith(multiChar)) {
-                  argsArray += elem.dropRight(1)
-                } else {
-                  argsArray += elem
-                }
+                argsArray += elem.dropRight(until)
                 processElement(next, multi = false)
               }
             }
diff --git 
a/streampark-flink/streampark-flink-client/streampark-flink-client-core/src/main/scala/org/apache/streampark/flink/client/trait/FlinkClientTrait.scala
 
b/streampark-flink/streampark-flink-client/streampark-flink-client-core/src/main/scala/org/apache/streampark/flink/client/trait/FlinkClientTrait.scala
index b1077cd45..8fd010cc5 100644
--- 
a/streampark-flink/streampark-flink-client/streampark-flink-client-core/src/main/scala/org/apache/streampark/flink/client/trait/FlinkClientTrait.scala
+++ 
b/streampark-flink/streampark-flink-client/streampark-flink-client-core/src/main/scala/org/apache/streampark/flink/client/trait/FlinkClientTrait.scala
@@ -429,6 +429,7 @@ trait FlinkClientTrait extends Logger {
 
           val next = index + 1
           val elem = array(index).trim
+          val until = if (elem.endsWith(multiChar)) 1 else 0
 
           if (elem.isEmpty) {
             processElement(next, multi = false)
@@ -445,18 +446,10 @@ trait FlinkClientTrait extends Logger {
               }
             } else {
               if (elem.startsWith(multiChar)) {
-                if (elem.endsWith(multiChar)) {
-                  tempBuffer += elem.drop(1).dropRight(1)
-                } else {
-                  tempBuffer += elem.drop(1)
-                }
+                tempBuffer += elem.drop(1).dropRight(until)
                 processElement(next, multi = true)
               } else {
-                if (elem.endsWith(multiChar)) {
-                  argsArray += elem.dropRight(1)
-                } else {
-                  argsArray += elem
-                }
+                argsArray += elem.dropRight(until)
                 processElement(next, multi = false)
               }
             }