This is an automated email from the ASF dual-hosted git repository.
benjobs pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-streampark.git
The following commit(s) were added to refs/heads/dev by this push:
new ceaa0dcf9 [Polish] Fix error msg typo (#2955)
ceaa0dcf9 is described below
commit ceaa0dcf925a8aee5927e66b9a47370ce65562d3
Author: gongzhongqiang <[email protected]>
AuthorDate: Sun Aug 20 21:52:51 2023 +0800
[Polish] Fix error msg typo (#2955)
* [Polish] Fix error msg typo
* [Polish] Polish code
---------
Co-authored-by: gongzhongqiang <[email protected]>
---
.../apache/streampark/console/core/bean/AlertTemplate.java | 2 +-
.../core/controller/ApplicationBuildPipelineController.java | 12 ------------
.../service/alert/impl/DingTalkAlertNotifyServiceImpl.java | 2 +-
.../core/service/alert/impl/WeComAlertNotifyServiceImpl.java | 4 ++--
.../streampark/console/core/task/FlinkClusterWatcher.java | 2 +-
5 files changed, 5 insertions(+), 17 deletions(-)
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/bean/AlertTemplate.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/bean/AlertTemplate.java
index cff27da10..1607ccb1b 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/bean/AlertTemplate.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/bean/AlertTemplate.java
@@ -103,7 +103,7 @@ public class AlertTemplate implements Serializable {
}
private static class AlertTemplateBuilder {
- private AlertTemplate alertTemplate = new AlertTemplate();
+ private final AlertTemplate alertTemplate = new AlertTemplate();
public AlertTemplateBuilder setTitle(String title) {
alertTemplate.setTitle(title);
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/controller/ApplicationBuildPipelineController.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/controller/ApplicationBuildPipelineController.java
index b00c69fc7..14dcf7326 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/controller/ApplicationBuildPipelineController.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/controller/ApplicationBuildPipelineController.java
@@ -25,10 +25,6 @@ import
org.apache.streampark.console.core.bean.AppBuildDockerResolvedDetail;
import org.apache.streampark.console.core.entity.AppBuildPipeline;
import org.apache.streampark.console.core.enums.PermissionType;
import org.apache.streampark.console.core.service.AppBuildPipeService;
-import org.apache.streampark.console.core.service.ApplicationLogService;
-import org.apache.streampark.console.core.service.ApplicationService;
-import org.apache.streampark.console.core.service.FlinkEnvService;
-import org.apache.streampark.console.core.service.FlinkSqlService;
import org.apache.streampark.flink.packer.pipeline.DockerResolvedSnapshot;
import org.apache.streampark.flink.packer.pipeline.PipelineType;
@@ -59,14 +55,6 @@ public class ApplicationBuildPipelineController {
@Autowired private AppBuildPipeService appBuildPipeService;
- @Autowired private ApplicationService applicationService;
-
- @Autowired private FlinkSqlService flinkSqlService;
-
- @Autowired private ApplicationLogService applicationLogService;
-
- @Autowired private FlinkEnvService flinkEnvService;
-
/**
* Release application building pipeline.
*
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/alert/impl/DingTalkAlertNotifyServiceImpl.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/alert/impl/DingTalkAlertNotifyServiceImpl.java
index 7d0e2efa5..0b57be923 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/alert/impl/DingTalkAlertNotifyServiceImpl.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/alert/impl/DingTalkAlertNotifyServiceImpl.java
@@ -107,7 +107,7 @@ public class DingTalkAlertNotifyServiceImpl implements
AlertNotifyService {
} catch (AlertException alertException) {
throw alertException;
} catch (Exception e) {
- throw new AlertException("Failed send dingTalk alert", e);
+ throw new AlertException("Failed send DingTalk alert", e);
}
}
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/alert/impl/WeComAlertNotifyServiceImpl.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/alert/impl/WeComAlertNotifyServiceImpl.java
index 796c4a4a5..5d1daa268 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/alert/impl/WeComAlertNotifyServiceImpl.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/alert/impl/WeComAlertNotifyServiceImpl.java
@@ -93,7 +93,7 @@ public class WeComAlertNotifyServiceImpl implements
AlertNotifyService {
try {
robotResponse = alertRestTemplate.postForObject(url, entity,
RobotResponse.class);
} catch (Exception e) {
- log.error("Failed to request DingTalk robot alarm,\nurl:{}", url, e);
+ log.error("Failed to request WeCom robot alarm,\nurl:{}", url, e);
throw new AlertException(
String.format("Failed to request WeCom robot alert,\nurl:%s", url),
e);
}
@@ -104,7 +104,7 @@ public class WeComAlertNotifyServiceImpl implements
AlertNotifyService {
if (robotResponse.getErrcode() != 0) {
throw new AlertException(
String.format(
- "Failed to request DingTalk robot
alert,\nurl:%s,\nerrorCode:%d,\nerrorMsg:%s",
+ "Failed to request WeCom robot
alert,\nurl:%s,\nerrorCode:%d,\nerrorMsg:%s",
url, robotResponse.getErrcode(), robotResponse.getErrmsg()));
}
}
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/task/FlinkClusterWatcher.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/task/FlinkClusterWatcher.java
index c4480aadf..936a38111 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/task/FlinkClusterWatcher.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/task/FlinkClusterWatcher.java
@@ -296,6 +296,6 @@ public class FlinkClusterWatcher {
*/
public Boolean verifyClusterConnection(FlinkCluster flinkCluster) {
ClusterState clusterState = httpClusterState(flinkCluster);
- return ClusterState.isRunning(clusterState) ? true : false;
+ return ClusterState.isRunning(clusterState);
}
}
