[incubator-streampark] branch restresp updated: [Improve] formatter improvement

[benjobs]

This is an automated email from the ASF dual-hosted git repository.

benjobs pushed a commit to branch restresp
in repository https://gitbox.apache.org/repos/asf/incubator-streampark.git


The following commit(s) were added to refs/heads/restresp by this push:
     new 85fcc2fd8 [Improve] formatter improvement
85fcc2fd8 is described below

commit 85fcc2fd89fa1bb066ac6786ce4ddc05cf6f1af4
Author: benjobs <benj...@gmail.com>
AuthorDate: Fri Sep 15 11:48:01 2023 +0800

    [Improve] formatter improvement
---
 .../java/org/apache/streampark/console/base/domain/RestResponse.java | 5 +++--
 .../streampark/console/base/handler/GlobalExceptionHandler.java      | 4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git 
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/base/domain/RestResponse.java
 
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/base/domain/RestResponse.java
index 9b1186a05..e016c9aae 100644
--- 
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/base/domain/RestResponse.java
+++ 
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/base/domain/RestResponse.java
@@ -17,9 +17,10 @@
 
 package org.apache.streampark.console.base.domain;
 
+import org.slf4j.helpers.MessageFormatter;
+
 import javax.validation.constraints.NotNull;
 
-import java.util.Formatter;
 import java.util.HashMap;
 
 public class RestResponse extends HashMap<String, Object> {
@@ -49,7 +50,7 @@ public class RestResponse extends HashMap<String, Object> {
   }
 
   public static RestResponse fail(Long code, String format, Object... args) {
-    String message = new Formatter().format(format, args).toString();
+    String message = MessageFormatter.arrayFormat(format, args).getMessage();
     RestResponse resp = new RestResponse();
     resp.put(STATUS_KEY, STATUS_FAIL);
     resp.put(MESSAGE_KEY, message);
diff --git 
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/base/handler/GlobalExceptionHandler.java
 
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/base/handler/GlobalExceptionHandler.java
index 8e059790c..c7597504b 100644
--- 
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/base/handler/GlobalExceptionHandler.java
+++ 
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/base/handler/GlobalExceptionHandler.java
@@ -52,7 +52,7 @@ public class GlobalExceptionHandler {
   @ResponseStatus(HttpStatus.INTERNAL_SERVER_ERROR)
   public RestResponse handleException(Exception e) {
     log.info("Internal server error：", e);
-    return RestResponse.fail(ResponseCode.CODE_FAIL, "internal server error: 
%s", e.getMessage());
+    return RestResponse.fail(ResponseCode.CODE_FAIL, "internal server error: 
{}", e.getMessage());
   }
 
   @ExceptionHandler(value = HttpRequestMethodNotSupportedException.class)
@@ -60,7 +60,7 @@ public class GlobalExceptionHandler {
   public RestResponse handleException(HttpRequestMethodNotSupportedException 
e) {
     log.info("not supported request method，exception：{}", e.getMessage());
     return RestResponse.fail(
-        ResponseCode.CODE_FAIL, "not supported request method，exception：%s", 
e.getMessage());
+        ResponseCode.CODE_FAIL, "not supported request method，exception：{}", 
e.getMessage());
   }
 
   @ExceptionHandler(value = AbstractApiException.class)