This is an automated email from the ASF dual-hosted git repository.
benjobs pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-streampark.git
The following commit(s) were added to refs/heads/dev by this push:
new 6b3407479 [Polish] Remove redundant @Transactional annotations (#3190)
6b3407479 is described below
commit 6b3407479c5273c8662a3f09484c08ce467498f9
Author: gongzhongqiang <[email protected]>
AuthorDate: Tue Sep 26 18:15:18 2023 +0800
[Polish] Remove redundant @Transactional annotations (#3190)
---
.../core/service/application/impl/ApplicationActionServiceImpl.java | 1 -
.../core/service/application/impl/ApplicationManageServiceImpl.java | 4 ----
.../console/core/service/impl/ApplicationBackUpServiceImpl.java | 2 --
.../console/core/service/impl/ApplicationConfigServiceImpl.java | 4 ----
.../streampark/console/core/service/impl/FlinkClusterServiceImpl.java | 1 -
.../streampark/console/core/service/impl/FlinkSqlServiceImpl.java | 1 -
.../streampark/console/core/service/impl/ProjectServiceImpl.java | 2 --
.../streampark/console/core/service/impl/ResourceServiceImpl.java | 2 --
8 files changed, 17 deletions(-)
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/application/impl/ApplicationActionServiceImpl.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/application/impl/ApplicationActionServiceImpl.java
index 0a478c357..223264317 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/application/impl/ApplicationActionServiceImpl.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/application/impl/ApplicationActionServiceImpl.java
@@ -374,7 +374,6 @@ public class ApplicationActionServiceImpl extends
ServiceImpl<ApplicationMapper,
}
@Override
- @Transactional(rollbackFor = {Exception.class})
public void start(Application appParam, boolean auto) throws Exception {
// 1) check application
final Application application = getById(appParam.getId());
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/application/impl/ApplicationManageServiceImpl.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/application/impl/ApplicationManageServiceImpl.java
index ae142bd59..ddd4ca148 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/application/impl/ApplicationManageServiceImpl.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/application/impl/ApplicationManageServiceImpl.java
@@ -154,7 +154,6 @@ public class ApplicationManageServiceImpl extends
ServiceImpl<ApplicationMapper,
}
@Override
- @Transactional(rollbackFor = {Exception.class})
public Boolean delete(Application appParam) {
Application application = getById(appParam.getId());
@@ -287,7 +286,6 @@ public class ApplicationManageServiceImpl extends
ServiceImpl<ApplicationMapper,
@SneakyThrows
@Override
- @Transactional(rollbackFor = {Exception.class})
public boolean create(Application appParam) {
ApiAlertException.throwIfNull(
appParam.getTeamId(), "The teamId can't be null. Create application
failed.");
@@ -357,7 +355,6 @@ public class ApplicationManageServiceImpl extends
ServiceImpl<ApplicationMapper,
@SuppressWarnings("checkstyle:WhitespaceAround")
@Override
@SneakyThrows
- @Transactional(rollbackFor = {Exception.class})
public Long copy(Application appParam) {
boolean existsByJobName = this.existsByJobName(appParam.getJobName());
ApiAlertException.throwIfFalse(
@@ -441,7 +438,6 @@ public class ApplicationManageServiceImpl extends
ServiceImpl<ApplicationMapper,
}
@Override
- @Transactional(rollbackFor = {Exception.class})
public boolean update(Application appParam) {
Application application = getById(appParam.getId());
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ApplicationBackUpServiceImpl.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ApplicationBackUpServiceImpl.java
index d7ae18d6e..72124b81d 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ApplicationBackUpServiceImpl.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ApplicationBackUpServiceImpl.java
@@ -71,7 +71,6 @@ public class ApplicationBackUpServiceImpl
}
@Override
- @Transactional(rollbackFor = {Exception.class})
public void rollback(ApplicationBackUp bakParam) {
Application application =
applicationManageService.getById(bakParam.getAppId());
@@ -192,7 +191,6 @@ public class ApplicationBackUpServiceImpl
}
@Override
- @Transactional(rollbackFor = {Exception.class})
public void backup(Application appParam, FlinkSql flinkSqlParam) {
// basic configuration file backup
String appHome =
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ApplicationConfigServiceImpl.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ApplicationConfigServiceImpl.java
index d5f5da1f2..f24fd38fb 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ApplicationConfigServiceImpl.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ApplicationConfigServiceImpl.java
@@ -64,7 +64,6 @@ public class ApplicationConfigServiceImpl
@Autowired private EffectiveService effectiveService;
@Override
- @Transactional(rollbackFor = {Exception.class})
public synchronized void create(Application application, Boolean latest) {
String decode = new
String(Base64.getDecoder().decode(application.getConfig()));
String config = DeflaterUtils.zipString(decode.trim());
@@ -89,7 +88,6 @@ public class ApplicationConfigServiceImpl
this.setLatestOrEffective(latest, applicationConfig.getId(),
application.getId());
}
- @Transactional(rollbackFor = {Exception.class})
public void setLatest(Long appId, Long configId) {
LambdaUpdateWrapper<ApplicationConfig> updateWrapper =
Wrappers.lambdaUpdate();
updateWrapper.set(ApplicationConfig::getLatest,
false).eq(ApplicationConfig::getAppId, appId);
@@ -101,7 +99,6 @@ public class ApplicationConfigServiceImpl
}
@Override
- @Transactional(rollbackFor = {Exception.class})
public synchronized void update(Application application, Boolean latest) {
// flink sql job
ApplicationConfig latestConfig = getLatest(application.getId());
@@ -189,7 +186,6 @@ public class ApplicationConfigServiceImpl
}
@Override
- @Transactional(rollbackFor = {Exception.class})
public ApplicationConfig getEffective(Long appId) {
return baseMapper.getEffective(appId);
}
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/FlinkClusterServiceImpl.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/FlinkClusterServiceImpl.java
index 5b8d6f703..275c08b05 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/FlinkClusterServiceImpl.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/FlinkClusterServiceImpl.java
@@ -170,7 +170,6 @@ public class FlinkClusterServiceImpl extends
ServiceImpl<FlinkClusterMapper, Fli
}
@Override
- @Transactional(rollbackFor = {Exception.class})
public void start(FlinkCluster cluster) {
FlinkCluster flinkCluster = getById(cluster.getId());
try {
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/FlinkSqlServiceImpl.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/FlinkSqlServiceImpl.java
index ded40a9a1..8fb5a25d9 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/FlinkSqlServiceImpl.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/FlinkSqlServiceImpl.java
@@ -95,7 +95,6 @@ public class FlinkSqlServiceImpl extends
ServiceImpl<FlinkSqlMapper, FlinkSql>
}
@Override
- @Transactional(rollbackFor = {Exception.class})
public void create(FlinkSql flinkSql) {
Integer version = this.baseMapper.getLatestVersion(flinkSql.getAppId());
flinkSql.setVersion(version == null ? 1 : version + 1);
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ProjectServiceImpl.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ProjectServiceImpl.java
index a34c71a01..ab1620115 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ProjectServiceImpl.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ProjectServiceImpl.java
@@ -114,7 +114,6 @@ public class ProjectServiceImpl extends
ServiceImpl<ProjectMapper, Project>
}
@Override
- @Transactional(rollbackFor = {Exception.class})
public boolean update(Project projectParam) {
Project project = getById(projectParam.getId());
Utils.notNull(project);
@@ -158,7 +157,6 @@ public class ProjectServiceImpl extends
ServiceImpl<ProjectMapper, Project>
}
@Override
- @Transactional(rollbackFor = {Exception.class})
public boolean delete(Long id) {
Project project = getById(id);
Utils.notNull(project);
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ResourceServiceImpl.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ResourceServiceImpl.java
index b09cf590e..26c46d8d0 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ResourceServiceImpl.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ResourceServiceImpl.java
@@ -95,8 +95,6 @@ public class ResourceServiceImpl extends
ServiceImpl<ResourceMapper, Resource>
@Autowired private CommonService commonService;
@Autowired private FlinkSqlService flinkSqlService;
- public ResourceServiceImpl() {}
-
@Override
public IPage<Resource> page(Resource resource, RestRequest restRequest) {
if (resource.getTeamId() == null) {
