This is an automated email from the ASF dual-hosted git repository.

benjobs pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-streampark.git


The following commit(s) were added to refs/heads/dev by this push:
     new b6486807b [ISSUE-3110][Improve] Improve streampark-testcontainer 
module based on [3.3 Methods Rule] (#3232)
b6486807b is described below

commit b6486807b8edf5a4412f7fbb2dc6ff1e849516f3
Author: Yuepeng Pan <[email protected]>
AuthorDate: Tue Oct 10 19:38:42 2023 -0500

    [ISSUE-3110][Improve] Improve streampark-testcontainer module based on [3.3 
Methods Rule] (#3232)
---
 .../java/org/apache/streampark/testcontainer/flink/FlinkContainer.java  | 1 +
 .../streampark/testcontainer/flink/FlinkStandaloneSessionCluster.java   | 2 ++
 2 files changed, 3 insertions(+)

diff --git 
a/streampark-tests/streampark-testcontainer/src/main/java/org/apache/streampark/testcontainer/flink/FlinkContainer.java
 
b/streampark-tests/streampark-testcontainer/src/main/java/org/apache/streampark/testcontainer/flink/FlinkContainer.java
index 2c85b86c8..e28028829 100644
--- 
a/streampark-tests/streampark-testcontainer/src/main/java/org/apache/streampark/testcontainer/flink/FlinkContainer.java
+++ 
b/streampark-tests/streampark-testcontainer/src/main/java/org/apache/streampark/testcontainer/flink/FlinkContainer.java
@@ -55,6 +55,7 @@ class FlinkContainer extends GenericContainer<FlinkContainer> 
{
     Optional.ofNullable(slf4jLogConsumer).ifPresent(this::withLogConsumer);
   }
 
+  @Nonnull
   protected String getFlinkContainerName() {
     if (component == JOBMANAGER) {
       return JOBMANAGER.getName();
diff --git 
a/streampark-tests/streampark-testcontainer/src/main/java/org/apache/streampark/testcontainer/flink/FlinkStandaloneSessionCluster.java
 
b/streampark-tests/streampark-testcontainer/src/main/java/org/apache/streampark/testcontainer/flink/FlinkStandaloneSessionCluster.java
index c238675d5..9c989957b 100644
--- 
a/streampark-tests/streampark-testcontainer/src/main/java/org/apache/streampark/testcontainer/flink/FlinkStandaloneSessionCluster.java
+++ 
b/streampark-tests/streampark-testcontainer/src/main/java/org/apache/streampark/testcontainer/flink/FlinkStandaloneSessionCluster.java
@@ -27,6 +27,7 @@ import org.testcontainers.containers.wait.strategy.Wait;
 import org.testcontainers.lifecycle.Startable;
 import org.testcontainers.utility.DockerImageName;
 
+import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 
 import java.time.Duration;
@@ -93,6 +94,7 @@ public class FlinkStandaloneSessionCluster implements 
Startable {
     }
   }
 
+  @Nonnull
   public String getFlinkJobManagerUrl() {
     return String.format(
         "http://%s:%s";, jobManagerContainer.getHost(), 
jobManagerContainer.getMappedPort(WEB_PORT));

Reply via email to