This is an automated email from the ASF dual-hosted git repository.
benjobs pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-streampark.git
The following commit(s) were added to refs/heads/dev by this push:
new 4fab36715 [ISSUE-3061][Improve] Improve streampark-common module base
on [4 Exception Processing] (#3266)
4fab36715 is described below
commit 4fab3671553b3409aa68940d879cbda5efa494d3
Author: Yuepeng Pan <[email protected]>
AuthorDate: Sun Oct 22 23:15:31 2023 +0800
[ISSUE-3061][Improve] Improve streampark-common module base on [4 Exception
Processing] (#3266)
---
.../src/main/scala/org/apache/streampark/common/conf/ConfigOption.scala | 2 +-
.../scala/org/apache/streampark/common/conf/InternalConfigHolder.scala | 2 +-
.../main/scala/org/apache/streampark/common/util/ClassLoaderUtils.scala | 2 +-
.../src/main/scala/org/apache/streampark/common/util/HadoopUtils.scala | 2 +-
.../src/main/scala/org/apache/streampark/common/util/Logger.scala | 2 +-
.../scala/org/apache/streampark/common/util/SystemPropertyUtils.scala | 2 +-
.../src/main/scala/org/apache/streampark/common/util/Utils.scala | 2 +-
7 files changed, 7 insertions(+), 7 deletions(-)
diff --git
a/streampark-common/src/main/scala/org/apache/streampark/common/conf/ConfigOption.scala
b/streampark-common/src/main/scala/org/apache/streampark/common/conf/ConfigOption.scala
index 22ac7de64..81cda957d 100644
---
a/streampark-common/src/main/scala/org/apache/streampark/common/conf/ConfigOption.scala
+++
b/streampark-common/src/main/scala/org/apache/streampark/common/conf/ConfigOption.scala
@@ -50,7 +50,7 @@ case class ConfigOption[T](
case null =>
if (required) {
prop.get(fullKey) match {
- case null => throw error("is require")
+ case null => throw error("Is require")
case v => v.toString.cast[T](classType)
}
} else {
diff --git
a/streampark-common/src/main/scala/org/apache/streampark/common/conf/InternalConfigHolder.scala
b/streampark-common/src/main/scala/org/apache/streampark/common/conf/InternalConfigHolder.scala
index b19e49480..f6631b697 100644
---
a/streampark-common/src/main/scala/org/apache/streampark/common/conf/InternalConfigHolder.scala
+++
b/streampark-common/src/main/scala/org/apache/streampark/common/conf/InternalConfigHolder.scala
@@ -103,7 +103,7 @@ object InternalConfigHolder extends Logger {
SystemPropertyUtils.get(key) match {
case v if v != null => v.cast[T](config.classType)
case _ =>
- throw new IllegalArgumentException(s"config key has not been
registered: $key")
+ throw new IllegalArgumentException(s"Config key has not been
registered: $key")
}
case conf: InternalOption => conf.defaultValue.asInstanceOf[T]
}
diff --git
a/streampark-common/src/main/scala/org/apache/streampark/common/util/ClassLoaderUtils.scala
b/streampark-common/src/main/scala/org/apache/streampark/common/util/ClassLoaderUtils.scala
index eb3f3dadc..e830d20c6 100644
---
a/streampark-common/src/main/scala/org/apache/streampark/common/util/ClassLoaderUtils.scala
+++
b/streampark-common/src/main/scala/org/apache/streampark/common/util/ClassLoaderUtils.scala
@@ -18,7 +18,7 @@ package org.apache.streampark.common.util
import java.io.{File, IOException}
import java.net.{URL, URLClassLoader}
-import java.util.function.{Consumer, Supplier}
+import java.util.function.Supplier
import scala.collection.mutable.ArrayBuffer
diff --git
a/streampark-common/src/main/scala/org/apache/streampark/common/util/HadoopUtils.scala
b/streampark-common/src/main/scala/org/apache/streampark/common/util/HadoopUtils.scala
index 0ca669094..a2ae4bb90 100644
---
a/streampark-common/src/main/scala/org/apache/streampark/common/util/HadoopUtils.scala
+++
b/streampark-common/src/main/scala/org/apache/streampark/common/util/HadoopUtils.scala
@@ -287,7 +287,7 @@ object HadoopUtils extends Logger {
val tmpDir = FileUtils.createTempDir()
val fs = FileSystem.get(new Configuration)
val sourcePath = fs.makeQualified(new Path(jarOnHdfs))
- if (!fs.exists(sourcePath)) throw new IOException(s"jar file: $jarOnHdfs
doesn't exist.")
+ if (!fs.exists(sourcePath)) throw new IOException(s"Jar file: $jarOnHdfs
doesn't exist.")
val destPath = new Path(tmpDir.getAbsolutePath + "/" + sourcePath.getName)
fs.copyToLocalFile(sourcePath, destPath)
new File(destPath.toString).getAbsolutePath
diff --git
a/streampark-common/src/main/scala/org/apache/streampark/common/util/Logger.scala
b/streampark-common/src/main/scala/org/apache/streampark/common/util/Logger.scala
index 0b97498b1..f17465e6b 100644
---
a/streampark-common/src/main/scala/org/apache/streampark/common/util/Logger.scala
+++
b/streampark-common/src/main/scala/org/apache/streampark/common/util/Logger.scala
@@ -121,7 +121,7 @@ private[this] object LoggerFactory extends
LoggerFactoryBinder {
override def getLoggerFactory: ILoggerFactory = {
if (contextSelectorBinder.getContextSelector == null) {
throw new IllegalStateException(
- "contextSelector cannot be null. See also " + CoreConstants.CODES_URL
+ "#null_CS")
+ "'contextSelector' cannot be null. See also " +
CoreConstants.CODES_URL + "#null_CS")
}
contextSelectorBinder.getContextSelector.getLoggerContext
}
diff --git
a/streampark-common/src/main/scala/org/apache/streampark/common/util/SystemPropertyUtils.scala
b/streampark-common/src/main/scala/org/apache/streampark/common/util/SystemPropertyUtils.scala
index c29aa60bb..8c9b21355 100644
---
a/streampark-common/src/main/scala/org/apache/streampark/common/util/SystemPropertyUtils.scala
+++
b/streampark-common/src/main/scala/org/apache/streampark/common/util/SystemPropertyUtils.scala
@@ -43,7 +43,7 @@ object SystemPropertyUtils extends Logger {
def get(key: String, default: String): String = {
require(key != null, "[StreamPark] key must not be null.")
key match {
- case empty if empty.isEmpty => throw new IllegalArgumentException("key
must not be empty.")
+ case empty if empty.isEmpty => throw new IllegalArgumentException("Key
must not be empty.")
case other =>
Try {
System.getSecurityManager match {
diff --git
a/streampark-common/src/main/scala/org/apache/streampark/common/util/Utils.scala
b/streampark-common/src/main/scala/org/apache/streampark/common/util/Utils.scala
index 2cd008072..d56322982 100644
---
a/streampark-common/src/main/scala/org/apache/streampark/common/util/Utils.scala
+++
b/streampark-common/src/main/scala/org/apache/streampark/common/util/Utils.scala
@@ -66,7 +66,7 @@ object Utils extends Logger {
def required(expression: Boolean, errorMessage: Any): Unit = {
if (!expression) {
- throw new IllegalArgumentException(s"requirement failed:
${errorMessage.toString}")
+ throw new IllegalArgumentException(s"Requirement failed:
${errorMessage.toString}")
}
}