This is an automated email from the ASF dual-hosted git repository.

benjobs pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-streampark.git


The following commit(s) were added to refs/heads/dev by this push:
     new 4e2e9da0d [Improve][Flink] Improve deployreponse parameters (#3315)
4e2e9da0d is described below

commit 4e2e9da0d948bd7dfb4bba6800cec3b7ce9a27a3
Author: caicancai <[email protected]>
AuthorDate: Sun Nov 5 16:35:08 2023 +0800

    [Improve][Flink] Improve deployreponse parameters (#3315)
    
    * [Improve][Flink] Improve deployreponse parameters
---
 .../org/apache/streampark/flink/client/bean/DeployResponse.scala      | 4 +++-
 .../streampark/flink/client/impl/KubernetesSessionClientV2.scala      | 3 ++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git 
a/streampark-flink/streampark-flink-client/streampark-flink-client-api/src/main/scala/org/apache/streampark/flink/client/bean/DeployResponse.scala
 
b/streampark-flink/streampark-flink-client/streampark-flink-client-api/src/main/scala/org/apache/streampark/flink/client/bean/DeployResponse.scala
index 91b6ecad0..abab13b86 100644
--- 
a/streampark-flink/streampark-flink-client/streampark-flink-client-api/src/main/scala/org/apache/streampark/flink/client/bean/DeployResponse.scala
+++ 
b/streampark-flink/streampark-flink-client/streampark-flink-client-api/src/main/scala/org/apache/streampark/flink/client/bean/DeployResponse.scala
@@ -17,4 +17,6 @@
 
 package org.apache.streampark.flink.client.bean
 
-case class DeployResponse(address: String, clusterId: String)
+import javax.annotation.Nullable
+
+case class DeployResponse(@Nullable address: String = "", clusterId: String)
diff --git 
a/streampark-flink/streampark-flink-client/streampark-flink-client-core/src/main/scala/org/apache/streampark/flink/client/impl/KubernetesSessionClientV2.scala
 
b/streampark-flink/streampark-flink-client/streampark-flink-client-core/src/main/scala/org/apache/streampark/flink/client/impl/KubernetesSessionClientV2.scala
index 68a89cac0..d5e25ce5a 100644
--- 
a/streampark-flink/streampark-flink-client/streampark-flink-client-core/src/main/scala/org/apache/streampark/flink/client/impl/KubernetesSessionClientV2.scala
+++ 
b/streampark-flink/streampark-flink-client/streampark-flink-client-core/src/main/scala/org/apache/streampark/flink/client/impl/KubernetesSessionClientV2.scala
@@ -158,13 +158,14 @@ object KubernetesSessionClientV2 extends 
KubernetesClientV2Trait with Logger {
     FlinkK8sOperator.deployCluster(deployRequest.id, 
flinkDeployDef).runIOAsTry match {
       case Success(_) =>
         logInfo(richMsg("Flink Cluster has been submitted successfully."))
-        DeployResponse(null, deployRequest.clusterId)
       case Failure(err) =>
         logError(
           richMsg(s"Submit Flink Cluster fail 
in${deployRequest.executionMode.getName}_V2 mode!"),
           err)
         throw err
     }
+
+    DeployResponse(null, deployRequest.clusterId)
   }
 
   /** Shutdown Flink cluster. */

Reply via email to