This is an automated email from the ASF dual-hosted git repository.
benjobs pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-streampark.git
The following commit(s) were added to refs/heads/dev by this push:
new 0a660d091 [ISSUE-3064][Improve] Improve streampark-console method name
base on [3.1 Naming Style] (#3364)
0a660d091 is described below
commit 0a660d091b043f41668d5430acacc04c9846d87b
Author: VampireAchao <[email protected]>
AuthorDate: Thu Nov 30 13:43:05 2023 +0800
[ISSUE-3064][Improve] Improve streampark-console method name base on [3.1
Naming Style] (#3364)
---
.../apache/streampark/console/core/controller/FlinkSqlController.java | 2 +-
.../apache/streampark/console/core/controller/ProjectController.java | 4 ++--
.../org/apache/streampark/console/core/service/FlinkSqlService.java | 2 +-
.../org/apache/streampark/console/core/service/ProjectService.java | 4 ++--
.../streampark/console/core/service/impl/FlinkSqlServiceImpl.java | 2 +-
.../streampark/console/core/service/impl/ProjectServiceImpl.java | 4 ++--
6 files changed, 9 insertions(+), 9 deletions(-)
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/controller/FlinkSqlController.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/controller/FlinkSqlController.java
index 73e3db332..c407325ae 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/controller/FlinkSqlController.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/controller/FlinkSqlController.java
@@ -118,7 +118,7 @@ public class FlinkSqlController {
@Operation(summary = "List the applications sql histories")
@PostMapping("history")
public RestResponse sqlhistory(Application application) {
- List<FlinkSql> sqlList = flinkSqlService.history(application);
+ List<FlinkSql> sqlList = flinkSqlService.listFlinkSqlHistory(application);
return RestResponse.success(sqlList);
}
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/controller/ProjectController.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/controller/ProjectController.java
index 09dc17ab6..bbbb2f9d6 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/controller/ProjectController.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/controller/ProjectController.java
@@ -134,14 +134,14 @@ public class ProjectController {
@Operation(summary = "List project modules")
@PostMapping("modules")
public RestResponse modules(Long id) {
- List<String> result = projectService.modules(id);
+ List<String> result = projectService.listModules(id);
return RestResponse.success().data(result);
}
@Operation(summary = "List project jars")
@PostMapping("jars")
public RestResponse jars(Project project) {
- List<String> result = projectService.jars(project);
+ List<String> result = projectService.listJars(project);
return RestResponse.success().data(result);
}
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/FlinkSqlService.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/FlinkSqlService.java
index c310bf3e7..050d94903 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/FlinkSqlService.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/FlinkSqlService.java
@@ -38,7 +38,7 @@ public interface FlinkSqlService extends IService<FlinkSql> {
FlinkSql getLatestFlinkSql(Long appId, boolean decode);
- List<FlinkSql> history(Application application);
+ List<FlinkSql> listFlinkSqlHistory(Application application);
FlinkSql getCandidate(Long appId, CandidateTypeEnum type);
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/ProjectService.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/ProjectService.java
index 2f7ea6ef1..a935570cc 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/ProjectService.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/ProjectService.java
@@ -46,9 +46,9 @@ public interface ProjectService extends IService<Project> {
RestResponse getBuildLog(Long id, Long startOffset);
- List<String> modules(Long id);
+ List<String> listModules(Long id);
- List<String> jars(Project project);
+ List<String> listJars(Project project);
List<Map<String, Object>> listConf(Project project);
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/FlinkSqlServiceImpl.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/FlinkSqlServiceImpl.java
index 1ac67162d..54c03d5c8 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/FlinkSqlServiceImpl.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/FlinkSqlServiceImpl.java
@@ -118,7 +118,7 @@ public class FlinkSqlServiceImpl extends
ServiceImpl<FlinkSqlMapper, FlinkSql>
}
@Override
- public List<FlinkSql> history(Application application) {
+ public List<FlinkSql> listFlinkSqlHistory(Application application) {
LambdaQueryWrapper<FlinkSql> queryWrapper =
new LambdaQueryWrapper<FlinkSql>()
.eq(FlinkSql::getAppId, application.getId())
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ProjectServiceImpl.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ProjectServiceImpl.java
index ce3ec3d20..b07f6598d 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ProjectServiceImpl.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ProjectServiceImpl.java
@@ -229,7 +229,7 @@ public class ProjectServiceImpl extends
ServiceImpl<ProjectMapper, Project>
}
@Override
- public List<String> modules(Long id) {
+ public List<String> listModules(Long id) {
Project project = getById(id);
Utils.notNull(project);
@@ -245,7 +245,7 @@ public class ProjectServiceImpl extends
ServiceImpl<ProjectMapper, Project>
}
@Override
- public List<String> jars(Project project) {
+ public List<String> listJars(Project project) {
List<String> jarList = new ArrayList<>(0);
ApiAlertException.throwIfNull(
project.getModule(), "Project module can't be null, please check.");