This is an automated email from the ASF dual-hosted git repository.

benjobs pushed a commit to branch dev-2.1.3
in repository https://gitbox.apache.org/repos/asf/incubator-streampark.git


The following commit(s) were added to refs/heads/dev-2.1.3 by this push:
     new 89bb6edc1 [Improve] flink job on yarn exists check improvement
89bb6edc1 is described below

commit 89bb6edc1ac026800c09942221a81c2fe2a90793
Author: benjobs <[email protected]>
AuthorDate: Sat Dec 23 15:14:38 2023 +0800

    [Improve] flink job on yarn exists check improvement
---
 .../streampark/console/core/controller/ApplicationController.java     | 4 ++--
 .../apache/streampark/console/core/service/ApplicationService.java    | 2 +-
 .../streampark/console/core/service/impl/ApplicationServiceImpl.java  | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git 
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/controller/ApplicationController.java
 
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/controller/ApplicationController.java
index 61489b771..721338cbd 100644
--- 
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/controller/ApplicationController.java
+++ 
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/controller/ApplicationController.java
@@ -249,8 +249,8 @@ public class ApplicationController {
   @PermissionAction(id = "#app.id", type = PermissionType.APP)
   @PostMapping(value = "check_start")
   @RequiresPermissions("app:start")
-  public RestResponse checkStart(Long id) {
-    AppExistsState stateEnum = applicationService.checkStart(id);
+  public RestResponse checkStart(Application app) {
+    AppExistsState stateEnum = applicationService.checkStart(app);
     return RestResponse.success(stateEnum.get());
   }
 
diff --git 
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/ApplicationService.java
 
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/ApplicationService.java
index 8fb516b79..9193cefa3 100644
--- 
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/ApplicationService.java
+++ 
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/ApplicationService.java
@@ -121,5 +121,5 @@ public interface ApplicationService extends 
IService<Application> {
 
   String k8sStartLog(Long id, Integer offset, Integer limit) throws Exception;
 
-  AppExistsState checkStart(Long id);
+  AppExistsState checkStart(Application app);
 }
diff --git 
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ApplicationServiceImpl.java
 
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ApplicationServiceImpl.java
index 9e2c679e7..3812e29c0 100644
--- 
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ApplicationServiceImpl.java
+++ 
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ApplicationServiceImpl.java
@@ -639,8 +639,8 @@ public class ApplicationServiceImpl extends 
ServiceImpl<ApplicationMapper, Appli
   }
 
   @Override
-  public AppExistsState checkStart(Long id) {
-    Application application = getById(id);
+  public AppExistsState checkStart(Application appParam) {
+    Application application = getById(app.getId());
     if (application == null) {
       return AppExistsState.INVALID;
     }

Reply via email to