(incubator-streampark) branch dev updated: [Improve] maven build args check improvement (#3440)

[kriszu]

This is an automated email from the ASF dual-hosted git repository.

kriszu pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-streampark.git


The following commit(s) were added to refs/heads/dev by this push:
     new 88fe66ce4 [Improve] maven build args check improvement (#3440)
88fe66ce4 is described below

commit 88fe66ce45234c39c23b61a53d57228fa608c617
Author: benjobs <benj...@apache.org>
AuthorDate: Mon Jan 1 21:42:38 2024 +0800

    [Improve] maven build args check improvement (#3440)
    
    * [Improve] maven build args check improvement
    
    * [Improve] minor improvement
    
    * [Improve] iter bug fixed
    
    * [Improve] mvn build args improvement
    
    ---------
    
    Co-authored-by: benjobs <benj...@gmail.com>
---
 .../streampark/console/core/entity/Project.java    | 35 ++++++++--------------
 1 file changed, 12 insertions(+), 23 deletions(-)

diff --git 
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/entity/Project.java
 
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/entity/Project.java
index 653405ba0..fd68e3fc5 100644
--- 
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/entity/Project.java
+++ 
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/entity/Project.java
@@ -43,12 +43,12 @@ import org.eclipse.jgit.lib.Constants;
 import java.io.File;
 import java.io.IOException;
 import java.io.Serializable;
-import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Date;
+import java.util.Iterator;
 import java.util.List;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
-import java.util.stream.Collectors;
 
 @Slf4j
 @Data
@@ -255,30 +255,19 @@ public class Project implements Serializable {
       return dangerArgs;
     }
 
-    String[] args = param.split("\\s+");
-    List<String> dangerArgs = new ArrayList<>();
-    for (String arg : args) {
-      if (arg.length() == 1) {
-        if (arg.equals("|")) {
-          dangerArgs.add("|");
-        }
-        if (arg.equals("&")) {
-          dangerArgs.add("&");
-        }
-      } else {
-        arg = arg.substring(0, 2);
-        if (arg.equals("||")) {
-          dangerArgs.add("||");
-        }
-        if (arg.equals("&&")) {
-          dangerArgs.add("&&");
+    String result = null;
+    Iterator<String> dangerIter = Arrays.asList(";", "|", "&", ">").iterator();
+    String[] argsList = param.split("\\s+");
+    while (result == null && dangerIter.hasNext()) {
+      String danger = dangerIter.next();
+      for (String arg : argsList) {
+        if (arg.contains(danger)) {
+          result = arg;
+          break;
         }
       }
     }
-    if (!dangerArgs.isEmpty()) {
-      return dangerArgs.stream().collect(Collectors.joining(","));
-    }
-    return null;
+    return result;
   }
 
   @JsonIgnore