This is an automated email from the ASF dual-hosted git repository.

benjobs pushed a commit to branch dev-2.1.3
in repository https://gitbox.apache.org/repos/asf/incubator-streampark.git


The following commit(s) were added to refs/heads/dev-2.1.3 by this push:
     new 14881d6b6 [Improve] k8s session mode ingress config improvement
14881d6b6 is described below

commit 14881d6b614894a39834c11d482a69050dabdc03
Author: benjobs <[email protected]>
AuthorDate: Sat Jan 20 15:50:15 2024 +0800

    [Improve] k8s session mode ingress config improvement
---
 .../core/service/impl/FlinkClusterServiceImpl.java       | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git 
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/FlinkClusterServiceImpl.java
 
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/FlinkClusterServiceImpl.java
index 4b73ef388..9a2bf1792 100644
--- 
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/FlinkClusterServiceImpl.java
+++ 
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/FlinkClusterServiceImpl.java
@@ -180,7 +180,7 @@ public class FlinkClusterServiceImpl extends 
ServiceImpl<FlinkClusterMapper, Fli
                 + "failed, exception:\n"
                 + Utils.stringifyException(deployResponse.error()));
       } else {
-        // 2) set address.
+        // 2) setAddress
         if (ExecutionMode.YARN_SESSION.equals(executionModeEnum)) {
           String address =
               YarnUtils.getRMWebAppURL(true) + "/proxy/" + 
deployResponse.clusterId() + "/";
@@ -193,12 +193,14 @@ public class FlinkClusterServiceImpl extends 
ServiceImpl<FlinkClusterMapper, Fli
         flinkCluster.setException(null);
         updateById(flinkCluster);
 
-        // 3) k8s session ingress
-        try {
-          serviceHelper.configureIngress(
-              flinkCluster.getClusterId(), flinkCluster.getK8sNamespace());
-        } catch (KubernetesClientException e) {
-          log.info("Failed to create ingress: {}", e.getMessage());
+        // k8s session mode ingress
+        if (ExecutionMode.KUBERNETES_NATIVE_SESSION.equals(executionModeEnum)) 
{
+          try {
+            serviceHelper.configureIngress(
+                flinkCluster.getClusterId(), flinkCluster.getK8sNamespace());
+          } catch (KubernetesClientException e) {
+            log.info("Failed to create ingress: {}", e.getMessage());
+          }
         }
       }
     } catch (Exception e) {

Reply via email to