(incubator-streampark) branch dev-2.1.4 updated: [Improve] code style improvement

[benjobs]

This is an automated email from the ASF dual-hosted git repository.

benjobs pushed a commit to branch dev-2.1.4
in repository https://gitbox.apache.org/repos/asf/incubator-streampark.git


The following commit(s) were added to refs/heads/dev-2.1.4 by this push:
     new 848984cdd [Improve] code style improvement
848984cdd is described below

commit 848984cdd7b653868c627a3fcf919456b575dd4e
Author: benjobs <benj...@gmail.com>
AuthorDate: Fri Apr 5 20:36:50 2024 +0800

    [Improve] code style improvement
---
 .../org/apache/streampark/common/util/ReflectUtils.scala   |  2 +-
 .../org/apache/streampark/common/util/YarnUtils.scala      | 14 +++++---------
 .../streampark/console/core/task/FlinkAppHttpWatcher.java  |  1 +
 3 files changed, 7 insertions(+), 10 deletions(-)

diff --git 
a/streampark-common/src/main/scala/org/apache/streampark/common/util/ReflectUtils.scala
 
b/streampark-common/src/main/scala/org/apache/streampark/common/util/ReflectUtils.scala
index 15ea1910d..ef2deefc4 100644
--- 
a/streampark-common/src/main/scala/org/apache/streampark/common/util/ReflectUtils.scala
+++ 
b/streampark-common/src/main/scala/org/apache/streampark/common/util/ReflectUtils.scala
@@ -84,7 +84,7 @@ object ReflectUtils extends Logger {
         makeAccessible(field)
         return field
       } catch {
-        case e: NoSuchFieldException =>
+        case _: NoSuchFieldException =>
       }
       superClass = superClass.getSuperclass
     }
diff --git 
a/streampark-common/src/main/scala/org/apache/streampark/common/util/YarnUtils.scala
 
b/streampark-common/src/main/scala/org/apache/streampark/common/util/YarnUtils.scala
index cbfb6e0aa..6dbe28ad2 100644
--- 
a/streampark-common/src/main/scala/org/apache/streampark/common/util/YarnUtils.scala
+++ 
b/streampark-common/src/main/scala/org/apache/streampark/common/util/YarnUtils.scala
@@ -41,19 +41,20 @@ object YarnUtils extends Logger {
 
   private[this] var rmHttpURL: String = _
 
-  lazy val PROXY_YARN_URL = 
InternalConfigHolder.get[String](CommonConfig.STREAMPARK_PROXY_YARN_URL)
+  private lazy val PROXY_YARN_URL =
+    InternalConfigHolder.get[String](CommonConfig.STREAMPARK_PROXY_YARN_URL)
 
   /**
    * hadoop.http.authentication.type<br> get yarn http authentication 
mode.<br> ex: simple, kerberos
    *
    * @return
    */
-  lazy val hasYarnHttpKerberosAuth: Boolean = {
+  private lazy val hasYarnHttpKerberosAuth: Boolean = {
     val yarnHttpAuth: String = 
InternalConfigHolder.get[String](CommonConfig.STREAMPARK_YARN_AUTH)
     "kerberos".equalsIgnoreCase(yarnHttpAuth)
   }
 
-  lazy val hasYarnHttpSimpleAuth: Boolean = {
+  private lazy val hasYarnHttpSimpleAuth: Boolean = {
     val yarnHttpAuth: String = 
InternalConfigHolder.get[String](CommonConfig.STREAMPARK_YARN_AUTH)
     "simple".equalsIgnoreCase(yarnHttpAuth)
   }
@@ -216,9 +217,6 @@ object YarnUtils extends Logger {
     rmHttpURL
   }
 
-  def getYarnAppTrackingUrl(applicationId: ApplicationId): String =
-    HadoopUtils.yarnClient.getApplicationReport(applicationId).getTrackingUrl
-
   /**
    * @param url
    *   url
@@ -242,9 +240,7 @@ object YarnUtils extends Logger {
         Try(request(s"${getRMWebAppURL()}/$url", timeout)) match {
           case Success(v) => v
           case Failure(_) =>
-            Utils.retry[String](5) {
-              request(s"${getRMWebAppURL(true)}/$url", timeout)
-            } match {
+            Utils.retry[String](5)(request(s"${getRMWebAppURL(true)}/$url", 
timeout)) match {
               case Success(v) => v
               case Failure(e) =>
                 throw new IOException(s"yarnUtils restRequest retry 5 times 
all failed. detail: $e")
diff --git 
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/task/FlinkAppHttpWatcher.java
 
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/task/FlinkAppHttpWatcher.java
index 1c721b455..33fbcd310 100644
--- 
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/task/FlinkAppHttpWatcher.java
+++ 
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/task/FlinkAppHttpWatcher.java
@@ -515,6 +515,7 @@ public class FlinkAppHttpWatcher {
       default:
         application.setState(currentState.getValue());
         doPersistMetrics(application, false);
+        break;
     }
   }