(incubator-streampark) branch dev-2.1.4 updated: [Feature] Optimize log printing and return in GlobalExceptionHandler (#3705)

[cancai]

This is an automated email from the ASF dual-hosted git repository.

cancai pushed a commit to branch dev-2.1.4
in repository https://gitbox.apache.org/repos/asf/incubator-streampark.git


The following commit(s) were added to refs/heads/dev-2.1.4 by this push:
     new 769e51a98 [Feature] Optimize log printing and return in 
GlobalExceptionHandler (#3705)
769e51a98 is described below

commit 769e51a98e329432d375f84f0d49de1aa1487ca0
Author: ouyangwulin <mr.art...@gmail.com>
AuthorDate: Sun May 12 11:34:31 2024 +0800

    [Feature] Optimize log printing and return in GlobalExceptionHandler (#3705)
---
 .../console/base/handler/GlobalExceptionHandler.java        | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git 
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/base/handler/GlobalExceptionHandler.java
 
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/base/handler/GlobalExceptionHandler.java
index 238010975..9f7c3ae0e 100644
--- 
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/base/handler/GlobalExceptionHandler.java
+++ 
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/base/handler/GlobalExceptionHandler.java
@@ -17,6 +17,7 @@
 
 package org.apache.streampark.console.base.handler;
 
+import org.apache.streampark.common.util.Utils;
 import org.apache.streampark.console.base.domain.ResponseCode;
 import org.apache.streampark.console.base.domain.RestResponse;
 import org.apache.streampark.console.base.exception.AbstractApiException;
@@ -51,21 +52,21 @@ public class GlobalExceptionHandler {
   @ExceptionHandler(value = UnauthenticatedException.class)
   @ResponseStatus(HttpStatus.UNAUTHORIZED)
   public RestResponse handelUnauthenticatedException(UnauthenticatedException 
e) {
-    log.info("Unauthenticated: {}", e.getMessage());
+    log.error("Unauthenticated.", e);
     return RestResponse.fail("Unauthenticated.", 
ResponseCode.CODE_UNAUTHORIZED);
   }
 
   @ExceptionHandler(value = AuthenticationException.class)
   @ResponseStatus(HttpStatus.UNAUTHORIZED)
   public RestResponse handelUnauthenticatedException(AuthenticationException 
e) {
-    log.info("Permission denied: {}", e.getMessage());
+    log.error("Permission denied.", e);
     return RestResponse.fail("Permission denied.", 
ResponseCode.CODE_UNAUTHORIZED);
   }
 
   @ExceptionHandler(value = AbstractApiException.class)
   @ResponseStatus(HttpStatus.INTERNAL_SERVER_ERROR)
   public RestResponse handleException(AbstractApiException e) {
-    log.info("api exception：{}", e.getMessage());
+    log.error("api exception:", e);
     return RestResponse.fail(e.getMessage(), e.getResponseCode());
   }
 
@@ -73,7 +74,9 @@ public class GlobalExceptionHandler {
   @ResponseStatus(HttpStatus.INTERNAL_SERVER_ERROR)
   @Order(value = Ordered.HIGHEST_PRECEDENCE)
   public RestResponse handleException(Exception e) {
-    return RestResponse.fail("internal server error: " + e.getMessage(), 
ResponseCode.CODE_FAIL);
+    log.error("internal server error:", e);
+    return RestResponse.fail(
+        "internal server error: " + Utils.stringifyException(e), 
ResponseCode.CODE_FAIL);
   }
 
   /**
@@ -85,6 +88,7 @@ public class GlobalExceptionHandler {
   @ExceptionHandler(BindException.class)
   @ResponseStatus(HttpStatus.BAD_REQUEST)
   public RestResponse validExceptionHandler(BindException e) {
+    log.error("bind exception:", e);
     StringBuilder message = new StringBuilder();
     List<FieldError> fieldErrors = e.getBindingResult().getFieldErrors();
     for (FieldError error : fieldErrors) {
@@ -103,6 +107,7 @@ public class GlobalExceptionHandler {
   @ExceptionHandler(value = ConstraintViolationException.class)
   @ResponseStatus(HttpStatus.BAD_REQUEST)
   public RestResponse 
handleConstraintViolationException(ConstraintViolationException e) {
+    log.error("constraint violation exception:", e);
     StringBuilder message = new StringBuilder();
     Set<ConstraintViolation<?>> violations = e.getConstraintViolations();
     for (ConstraintViolation<?> violation : violations) {