This is an automated email from the ASF dual-hosted git repository.
cancai pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-streampark.git
The following commit(s) were added to refs/heads/dev by this push:
new 5c1ba5fbb [Improve] improve error log (#3721)
5c1ba5fbb is described below
commit 5c1ba5fbbd243cbcd8e5315016731f1ca88eb081
Author: Cancai Cai <[email protected]>
AuthorDate: Thu May 23 23:33:19 2024 +0800
[Improve] improve error log (#3721)
---
.../streampark/console/core/entity/FlinkCluster.java | 6 ++++--
.../core/service/impl/AppBuildPipeServiceImpl.java | 2 +-
.../console/core/service/impl/ProjectServiceImpl.java | 2 +-
.../console/core/service/impl/ResourceServiceImpl.java | 15 +++++++++++----
.../console/core/service/impl/SavePointServiceImpl.java | 4 ++--
.../console/core/service/impl/SettingServiceImpl.java | 2 +-
.../console/core/service/impl/SqlCompleteServiceImpl.java | 2 +-
7 files changed, 21 insertions(+), 12 deletions(-)
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/entity/FlinkCluster.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/entity/FlinkCluster.java
index 67637440b..d1ce09e77 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/entity/FlinkCluster.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/entity/FlinkCluster.java
@@ -42,6 +42,7 @@ import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.core.type.TypeReference;
import lombok.Data;
import lombok.SneakyThrows;
+import lombok.extern.slf4j.Slf4j;
import java.io.Serializable;
import java.net.URI;
@@ -52,6 +53,7 @@ import java.util.List;
import java.util.Map;
import java.util.concurrent.TimeUnit;
+@Slf4j
@Data
@TableName("t_flink_cluster")
public class FlinkCluster implements Serializable {
@@ -152,8 +154,8 @@ public class FlinkCluster implements Serializable {
this.address,
RequestConfig.custom().setConnectTimeout(2000,
TimeUnit.MILLISECONDS).build());
return new URI(address);
- } catch (Exception ignored) {
- //
+ } catch (Exception e) {
+ log.error("FlinkCluster getRemoteURI error", e);
}
return null;
}
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/AppBuildPipeServiceImpl.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/AppBuildPipeServiceImpl.java
index 3370e6652..9d4bbe310 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/AppBuildPipeServiceImpl.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/AppBuildPipeServiceImpl.java
@@ -712,7 +712,7 @@ public class AppBuildPipeServiceImpl
});
return dependencyInfo.merge(mvnArtifacts, jarLibs);
} catch (Exception e) {
- log.warn("Merge team dependency failed.", e);
+ log.error("Merge team dependency failed.", e);
return dependencyInfo;
}
}
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ProjectServiceImpl.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ProjectServiceImpl.java
index f6097bb39..aebf67033 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ProjectServiceImpl.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ProjectServiceImpl.java
@@ -347,7 +347,7 @@ public class ProjectServiceImpl extends
ServiceImpl<ProjectMapper, Project>
}
return confList;
} catch (Exception e) {
- log.info(e.getMessage());
+ log.error("List project conf failed", e);
}
return null;
}
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ResourceServiceImpl.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ResourceServiceImpl.java
index 7a82a2bb9..193eec6d3 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ResourceServiceImpl.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ResourceServiceImpl.java
@@ -388,7 +388,13 @@ public class ResourceServiceImpl extends
ServiceImpl<ResourceMapper, Resource>
try {
connectorResource.setClassName(factoryClassName);
connectorResource.setFactoryIdentifier(factory.factoryIdentifier());
- } catch (Exception ignored) {
+ } catch (Exception e) {
+ log.error(
+ "Failed to set class name or factory identifier for connector
resource. Class name: "
+ + factoryClassName
+ + ", Factory identifier: "
+ + factory.factoryIdentifier(),
+ e);
}
try {
@@ -397,8 +403,8 @@ public class ResourceServiceImpl extends
ServiceImpl<ResourceMapper, Resource>
.requiredOptions()
.forEach(x -> requiredOptions.put(x.key(),
getOptionDefaultValue(x)));
connectorResource.setRequiredOptions(requiredOptions);
- } catch (Exception ignored) {
-
+ } catch (Exception e) {
+ log.error("Failed to set required options for connector resource.
" + e);
}
try {
@@ -407,7 +413,8 @@ public class ResourceServiceImpl extends
ServiceImpl<ResourceMapper, Resource>
.optionalOptions()
.forEach(x -> optionalOptions.put(x.key(),
getOptionDefaultValue(x)));
connectorResource.setOptionalOptions(optionalOptions);
- } catch (Exception ignored) {
+ } catch (Exception e) {
+ log.error("Fail to set optional options for connector resource. "
+ e);
}
return connectorResource;
}
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/SavePointServiceImpl.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/SavePointServiceImpl.java
index 00b8942e6..b70dfbfa1 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/SavePointServiceImpl.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/SavePointServiceImpl.java
@@ -399,7 +399,7 @@ public class SavePointServiceImpl extends
ServiceImpl<SavePointMapper, SavePoint
log.warn(
"This value of dynamicProperties key: state.checkpoints.num-retained
is invalid, must be greater than 0");
} catch (NumberFormatException e) {
- log.warn(
+ log.error(
"This value of dynamicProperties key: state.checkpoints.num-retained
invalid, must be number");
}
return Optional.empty();
@@ -428,7 +428,7 @@ public class SavePointServiceImpl extends
ServiceImpl<SavePointMapper, SavePoint
"The value of key: state.checkpoints.num-retained in flink-conf.yaml
is invalid, must be greater than 0, default value: {} will be used",
MAX_RETAINED_CHECKPOINTS.defaultValue());
} catch (NumberFormatException e) {
- log.warn(
+ log.error(
"The value of key: state.checkpoints.num-retained in flink-conf.yaml
is invalid, must be number, flink env: {}, default value: {} will be used",
flinkEnv.getFlinkHome(),
flinkConfNumRetained);
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/SettingServiceImpl.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/SettingServiceImpl.java
index 3d49aad13..1661f41ed 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/SettingServiceImpl.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/SettingServiceImpl.java
@@ -191,7 +191,7 @@ public class SettingServiceImpl extends
ServiceImpl<SettingMapper, Setting>
}
return senderEmail;
} catch (Exception e) {
- log.warn("Fault Alert Email is not set.");
+ log.error("Fault Alert Email is not set.");
}
return null;
}
diff --git
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/SqlCompleteServiceImpl.java
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/SqlCompleteServiceImpl.java
index d2ba899f5..080df5599 100644
---
a/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/SqlCompleteServiceImpl.java
+++
b/streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/SqlCompleteServiceImpl.java
@@ -145,7 +145,7 @@ public class SqlCompleteServiceImpl implements
SqlCompleteService {
}
scanner.close();
} catch (Exception e) {
- log.info("Error while FstTree ini that: {}", e.getMessage());
+ log.error("Error while FstTree ini that: {}", e.getMessage());
}
}
