[incubator-streampipes] branch dev updated: [hotfix] Remove failed pipeline element invocations from running instance map

[riemer]

This is an automated email from the ASF dual-hosted git repository.

riemer pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-streampipes.git


The following commit(s) were added to refs/heads/dev by this push:
     new db0c2d4  [hotfix] Remove failed pipeline element invocations from 
running instance map
db0c2d4 is described below

commit db0c2d4a1810fb7cd3e2a99f96d2fccb477d844a
Author: Dominik Riemer <rie...@fzi.de>
AuthorDate: Mon May 24 12:02:28 2021 +0200

    [hotfix] Remove failed pipeline element invocations from running instance 
map
---
 .../streampipes/container/api/InvocablePipelineElementResource.java | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git 
a/streampipes-container/src/main/java/org/apache/streampipes/container/api/InvocablePipelineElementResource.java
 
b/streampipes-container/src/main/java/org/apache/streampipes/container/api/InvocablePipelineElementResource.java
index d9bed39..bbcdec3 100644
--- 
a/streampipes-container/src/main/java/org/apache/streampipes/container/api/InvocablePipelineElementResource.java
+++ 
b/streampipes-container/src/main/java/org/apache/streampipes/container/api/InvocablePipelineElementResource.java
@@ -71,6 +71,12 @@ public abstract class InvocablePipelineElementResource<I 
extends InvocableStream
                 if (!RunningInstances.INSTANCE.exists(runningInstanceId)) {
                     RunningInstances.INSTANCE.add(runningInstanceId, graph, 
declarer.getClass().newInstance());
                     Response resp = 
RunningInstances.INSTANCE.getInvocation(runningInstanceId).invokeRuntime(graph);
+                    if (!resp.isSuccess()) {
+                        LOG.error("Could not invoke pipeline element {} due to 
the following error: {}",
+                                graph.getName(),
+                                resp.getOptionalMessage());
+                        RunningInstances.INSTANCE.remove(runningInstanceId);
+                    }
                     return ok(resp);
                 } else {
                     LOG.info("Pipeline element {} with id {} seems to be 
already running, skipping invocation request.", graph.getName(), 
runningInstanceId);