This is an automated email from the ASF dual-hosted git repository.
riemer pushed a commit to branch
2112-changes-on-messaging-layer-configuration-on-ui-not-persisted
in repository https://gitbox.apache.org/repos/asf/streampipes.git
The following commit(s) were added to
refs/heads/2112-changes-on-messaging-layer-configuration-on-ui-not-persisted by
this push:
new 307c16f09 fix(#2112): Properly update broker configs
307c16f09 is described below
commit 307c16f092a48c5d3bbe43730959461d1ca0b219
Author: Dominik Riemer <[email protected]>
AuthorDate: Tue Oct 31 22:30:28 2023 +0100
fix(#2112): Properly update broker configs
---
.../broker-config/broker-config.component.html | 14 ++++++++++++--
.../broker-config/broker-config.component.ts | 8 +++++++-
.../messaging-configuration.component.html | 21 +++++++++++----------
3 files changed, 30 insertions(+), 13 deletions(-)
diff --git
a/ui/src/app/configuration/messaging-configuration/broker-config/broker-config.component.html
b/ui/src/app/configuration/messaging-configuration/broker-config/broker-config.component.html
index d97c4bd56..465d3d125 100644
---
a/ui/src/app/configuration/messaging-configuration/broker-config/broker-config.component.html
+++
b/ui/src/app/configuration/messaging-configuration/broker-config/broker-config.component.html
@@ -22,13 +22,23 @@
<div>
<mat-form-field class="form-field" fxFlex="100" color="accent">
<mat-label>Host</mat-label>
- <input matInput [(ngModel)]="host" type="text" />
+ <input
+ matInput
+ [(ngModel)]="host"
+ (ngModelChange)="hostChange.emit($event)"
+ type="text"
+ />
</mat-form-field>
</div>
<div>
<mat-form-field class="form-field" fxFlex="100" color="accent">
<mat-label>Port</mat-label>
- <input matInput [(ngModel)]="port" type="number" />
+ <input
+ matInput
+ [(ngModel)]="port"
+ (ngModelChange)="portChange.emit($event)"
+ type="number"
+ />
</mat-form-field>
</div>
</div>
diff --git
a/ui/src/app/configuration/messaging-configuration/broker-config/broker-config.component.ts
b/ui/src/app/configuration/messaging-configuration/broker-config/broker-config.component.ts
index 9a00398bb..9ce233c13 100644
---
a/ui/src/app/configuration/messaging-configuration/broker-config/broker-config.component.ts
+++
b/ui/src/app/configuration/messaging-configuration/broker-config/broker-config.component.ts
@@ -16,7 +16,7 @@
*
*/
-import { Component, Input } from '@angular/core';
+import { Component, EventEmitter, Input, Output } from '@angular/core';
@Component({
selector: 'sp-messaging-broker-config',
@@ -31,4 +31,10 @@ export class SpMessagingBrokerConfigComponent {
@Input()
port: number;
+
+ @Output()
+ hostChange = new EventEmitter<string>();
+
+ @Output()
+ portChange = new EventEmitter<number>();
}
diff --git
a/ui/src/app/configuration/messaging-configuration/messaging-configuration.component.html
b/ui/src/app/configuration/messaging-configuration/messaging-configuration.component.html
index 8f96bc886..f31c5fba3 100644
---
a/ui/src/app/configuration/messaging-configuration/messaging-configuration.component.html
+++
b/ui/src/app/configuration/messaging-configuration/messaging-configuration.component.html
@@ -171,26 +171,27 @@
<sp-split-section
title="Messaging layers"
subtitle="Manage messaging layer connectivity"
+ *ngIf="loadingCompleted"
>
<sp-messaging-broker-config
title="JMS"
- [host]="messagingSettings.jmsHost"
- [port]="messagingSettings.jmsPort"
+ [(host)]="messagingSettings.jmsHost"
+ [(port)]="messagingSettings.jmsPort"
></sp-messaging-broker-config>
<sp-messaging-broker-config
title="Kafka"
- [host]="messagingSettings.kafkaHost"
- [port]="messagingSettings.kafkaPort"
+ [(host)]="messagingSettings.kafkaHost"
+ [(port)]="messagingSettings.kafkaPort"
></sp-messaging-broker-config>
<sp-messaging-broker-config
title="MQTT"
- [host]="messagingSettings.mqttHost"
- [port]="messagingSettings.mqttPort"
+ [(host)]="messagingSettings.mqttHost"
+ [(port)]="messagingSettings.mqttPort"
></sp-messaging-broker-config>
<sp-messaging-broker-config
title="Nats"
- [host]="messagingSettings.natsHost"
- [port]="messagingSettings.natsPort"
+ [(host)]="messagingSettings.natsHost"
+ [(port)]="messagingSettings.natsPort"
></sp-messaging-broker-config>
<div fxLayout="column">
<div class="subsection-title">Pulsar</div>
@@ -205,8 +206,8 @@
</div>
<sp-messaging-broker-config
title="Zookeeper"
- [host]="messagingSettings.zookeeperHost"
- [port]="messagingSettings.zookeeperPort"
+ [(host)]="messagingSettings.zookeeperHost"
+ [(port)]="messagingSettings.zookeeperPort"
></sp-messaging-broker-config>
<div fxLayoutAlign="start center" class="mt-10">
<button
