(streampipes) branch 2252-enhance-data-lake-sink-schema-management-options updated: refactor(#2252): Some minor refactoring and cleanup

[zehnder]

This is an automated email from the ASF dual-hosted git repository.

zehnder pushed a commit to branch 
2252-enhance-data-lake-sink-schema-management-options
in repository https://gitbox.apache.org/repos/asf/streampipes.git


The following commit(s) were added to 
refs/heads/2252-enhance-data-lake-sink-schema-management-options by this push:
     new 3a59d67f4 refactor(#2252): Some minor refactoring and cleanup
3a59d67f4 is described below

commit 3a59d67f467af2bf00d00936e37f142a207436f0
Author: Philipp Zehnder <ten...@users.noreply.github.com>
AuthorDate: Thu Nov 30 18:22:59 2023 +0100

    refactor(#2252): Some minor refactoring and cleanup
---
 .../apache/streampipes/dataexplorer/commons/TimeSeriesStore.java | 6 ------
 .../streampipes/sinks/internal/jvm/datalake/DataLakeSink.java    | 9 ++++-----
 2 files changed, 4 insertions(+), 11 deletions(-)

diff --git 
a/streampipes-data-explorer-commons/src/main/java/org/apache/streampipes/dataexplorer/commons/TimeSeriesStore.java
 
b/streampipes-data-explorer-commons/src/main/java/org/apache/streampipes/dataexplorer/commons/TimeSeriesStore.java
index 31ce5cbf3..4bc662869 100644
--- 
a/streampipes-data-explorer-commons/src/main/java/org/apache/streampipes/dataexplorer/commons/TimeSeriesStore.java
+++ 
b/streampipes-data-explorer-commons/src/main/java/org/apache/streampipes/dataexplorer/commons/TimeSeriesStore.java
@@ -47,7 +47,6 @@ public class TimeSeriesStore {
     DataExplorerUtils.sanitizeAndRegisterAtDataLake(client, measure);
 
     if (enableImageStore) {
-      // TODO check if event properties are replaces correctly
       this.imageStore = new ImageStore(measure, environment);
     }
 
@@ -67,11 +66,6 @@ public class TimeSeriesStore {
     return true;
   }
 
-
-  public boolean alterRetentionTime(DataLakeMeasure dataLakeMeasure) {
-    return true;
-  }
-
   public void close() throws SpRuntimeException {
     if (imageStore != null) {
       try {
diff --git 
a/streampipes-extensions/streampipes-sinks-internal-jvm/src/main/java/org/apache/streampipes/sinks/internal/jvm/datalake/DataLakeSink.java
 
b/streampipes-extensions/streampipes-sinks-internal-jvm/src/main/java/org/apache/streampipes/sinks/internal/jvm/datalake/DataLakeSink.java
index 23557e7d7..78007a1aa 100644
--- 
a/streampipes-extensions/streampipes-sinks-internal-jvm/src/main/java/org/apache/streampipes/sinks/internal/jvm/datalake/DataLakeSink.java
+++ 
b/streampipes-extensions/streampipes-sinks-internal-jvm/src/main/java/org/apache/streampipes/sinks/internal/jvm/datalake/DataLakeSink.java
@@ -26,7 +26,6 @@ import org.apache.streampipes.model.DataSinkType;
 import org.apache.streampipes.model.datalake.DataLakeMeasure;
 import org.apache.streampipes.model.graph.DataSinkDescription;
 import org.apache.streampipes.model.runtime.Event;
-import org.apache.streampipes.model.schema.EventSchema;
 import org.apache.streampipes.model.schema.PropertyScope;
 import org.apache.streampipes.sdk.builder.DataSinkBuilder;
 import org.apache.streampipes.sdk.builder.StreamRequirementsBuilder;
@@ -64,11 +63,11 @@ public class DataLakeSink extends StreamPipesDataSink {
 
   @Override
   public void onInvocation(SinkParams parameters, EventSinkRuntimeContext 
runtimeContext) throws SpRuntimeException {
-    String timestampField = 
parameters.extractor().mappingPropertyValue(TIMESTAMP_MAPPING_KEY);
-    String measureName = 
parameters.extractor().singleValueParameter(DATABASE_MEASUREMENT_KEY, 
String.class);
-    EventSchema eventSchema = 
parameters.getInputSchemaInfos().get(0).getEventSchema();
+    var timestampField = 
parameters.extractor().mappingPropertyValue(TIMESTAMP_MAPPING_KEY);
+    var measureName = 
parameters.extractor().singleValueParameter(DATABASE_MEASUREMENT_KEY, 
String.class);
+    var eventSchema = parameters.getInputSchemaInfos().get(0).getEventSchema();
 
-    DataLakeMeasure measure = new DataLakeMeasure(measureName, timestampField, 
eventSchema);
+    var measure = new DataLakeMeasure(measureName, timestampField, 
eventSchema);
 
     this.timeSeriesStore = new TimeSeriesStore(Environments.getEnvironment(),
         runtimeContext.getStreamPipesClient(),