This is an automated email from the ASF dual-hosted git repository.
zehnder pushed a commit to branch
2964-timestamp-conversion-is-broken-in-adapters
in repository https://gitbox.apache.org/repos/asf/streampipes.git
The following commit(s) were added to
refs/heads/2964-timestamp-conversion-is-broken-in-adapters by this push:
new ea6b255d2d fix(#2964): Fix test valueRules.spec.ts
ea6b255d2d is described below
commit ea6b255d2d23cf0d002f5a813943845675b4cc82
Author: Philipp Zehnder <[email protected]>
AuthorDate: Wed Jun 26 22:18:00 2024 +0200
fix(#2964): Fix test valueRules.spec.ts
---
ui/cypress/support/utils/connect/ConnectBtns.ts | 20 +++++++++++++
.../utils/connect/ConnectEventSchemaUtils.ts | 34 ++++------------------
.../rules/{valueRules.ts => valueRules.spec.ts} | 0
3 files changed, 26 insertions(+), 28 deletions(-)
diff --git a/ui/cypress/support/utils/connect/ConnectBtns.ts
b/ui/cypress/support/utils/connect/ConnectBtns.ts
index f828bcf148..ad26055a88 100644
--- a/ui/cypress/support/utils/connect/ConnectBtns.ts
+++ b/ui/cypress/support/utils/connect/ConnectBtns.ts
@@ -71,6 +71,26 @@ export class ConnectBtns {
// ========================================================================
+ // ===================== Event Schema buttons ==========================
+
+ public static schemaUnitFromDropdown() {
+ return cy.dataCy('connect-schema-unit-from-dropdown');
+ }
+
+ public static schemaUnitTransformBtn() {
+ return cy.dataCy('connect-schema-unit-transform-btn');
+ }
+
+ public static schemaUnitToDropdown() {
+ return cy.dataCy('connect-schema-unit-to-dropdown');
+ }
+
+ public static saveEditProperty() {
+ return cy.dataCy('sp-save-edit-property');
+ }
+
+ // ========================================================================
+
// ===================== Format configurations ==========================
public static csvDelimiter() {
diff --git a/ui/cypress/support/utils/connect/ConnectEventSchemaUtils.ts
b/ui/cypress/support/utils/connect/ConnectEventSchemaUtils.ts
index 098ea68554..2026d110de 100644
--- a/ui/cypress/support/utils/connect/ConnectEventSchemaUtils.ts
+++ b/ui/cypress/support/utils/connect/ConnectEventSchemaUtils.ts
@@ -111,37 +111,15 @@ export class ConnectEventSchemaUtils {
toUnit: string,
) {
ConnectEventSchemaUtils.clickEditProperty(propertyName);
- cy.dataCy('connect-schema-unit-from-dropdown').type(fromUnit);
- cy.dataCy('connect-schema-unit-transform-btn').click();
- cy.dataCy('connect-schema-unit-to-dropdown')
- .click()
+ ConnectBtns.schemaUnitFromDropdown().type(fromUnit);
+ ConnectBtns.schemaUnitTransformBtn().click();
+ ConnectBtns.schemaUnitToDropdown().click();
+
+ ConnectBtns.schemaUnitToDropdown()
.get('mat-option')
.contains(toUnit)
.click();
- cy.dataCy('sp-save-edit-property').click();
-
- cy.dataCy('edit-' + propertyName.toLowerCase(), {
- timeout: 10000,
- }).click({ force: true });
-
- cy.dataCy('connect-schema-unit-from-dropdown').eq(0).clear();
- cy.dataCy('connect-schema-unit-from-dropdown').eq(0).type(fromUnit);
- cy.dataCy('connect-schema-unit-from-dropdown', {
- timeout: 10000,
- }).should('have.value', fromUnit);
- //cy.dataCy("connect-schema-unit-transform-btn").click();
- cy.dataCy('connect-schema-unit-to-dropdown')
- .contains(toUnit)
- .click({ force: true });
- cy.dataCy('connect-schema-unit-to-dropdown', {
- timeout: 10000,
- }).contains(toUnit);
-
- cy.dataCy('sp-save-edit-property', { timeout: 10000 }).should(
- 'have.length',
- 1,
- );
- cy.dataCy('sp-save-edit-property').click({ force: true });
+ ConnectBtns.saveEditProperty().click();
}
public static addStaticProperty(
diff --git a/ui/cypress/tests/adapter/rules/valueRules.ts
b/ui/cypress/tests/adapter/rules/valueRules.spec.ts
similarity index 100%
rename from ui/cypress/tests/adapter/rules/valueRules.ts
rename to ui/cypress/tests/adapter/rules/valueRules.spec.ts
