This is an automated email from the ASF dual-hosted git repository.
zehnder pushed a commit to branch
3430-filtering-for-numerical-dimension-properties-in-data-explorer
in repository https://gitbox.apache.org/repos/asf/streampipes.git
The following commit(s) were added to
refs/heads/3430-filtering-for-numerical-dimension-properties-in-data-explorer
by this push:
new 552a12fd7f fix(#3430): Add method to validate amount of table results
in data explorer
552a12fd7f is described below
commit 552a12fd7f43a5b84b90539a568bbabd432883b7
Author: Philipp Zehnder <[email protected]>
AuthorDate: Fri Jan 17 15:35:16 2025 +0100
fix(#3430): Add method to validate amount of table results in data explorer
---
.../support/utils/datalake/DataLakeWidgetTableUtils.ts | 12 ++++++++----
.../tests/datalake/missingDataInDataLake.spec.ts | 4 ++--
.../datalake/widgetDataConfiguration.smoke.spec.ts | 18 +++++++++---------
ui/cypress/tests/datalake/widgets/table.spec.ts | 5 ++---
4 files changed, 21 insertions(+), 18 deletions(-)
diff --git a/ui/cypress/support/utils/datalake/DataLakeWidgetTableUtils.ts
b/ui/cypress/support/utils/datalake/DataLakeWidgetTableUtils.ts
index 733f8616a0..d09177c6ea 100644
--- a/ui/cypress/support/utils/datalake/DataLakeWidgetTableUtils.ts
+++ b/ui/cypress/support/utils/datalake/DataLakeWidgetTableUtils.ts
@@ -17,13 +17,17 @@
*/
export class DataLakeWidgetTableUtils {
+ public static dataExplorerTableRowTimestamp() {
+ return cy.dataCy('data-explorer-table-row-timestamp', {
+ timeout: 10000,
+ });
+ }
+
/**
* Checks how many rows are visible within the table widget in the data
explorer
* @param amount of expected rows
*/
- public static checkRows(amount: number) {
- cy.dataCy('data-explorer-table-row-timestamp', {
- timeout: 10000,
- }).should('have.length', amount);
+ public static checkAmountOfRows(amount: number) {
+ this.dataExplorerTableRowTimestamp().should('have.length', amount);
}
}
diff --git a/ui/cypress/tests/datalake/missingDataInDataLake.spec.ts
b/ui/cypress/tests/datalake/missingDataInDataLake.spec.ts
index f547c61448..77e57710b1 100644
--- a/ui/cypress/tests/datalake/missingDataInDataLake.spec.ts
+++ b/ui/cypress/tests/datalake/missingDataInDataLake.spec.ts
@@ -34,13 +34,13 @@ describe('Test missing properties in data lake', () => {
it('Test table with missing properties', () => {
DataLakeUtils.addDataViewAndTableWidget(dataViewName, 'Persist');
- DataLakeWidgetTableUtils.checkRows(5);
+ DataLakeWidgetTableUtils.checkAmountOfRows(5);
DataLakeUtils.selectDataConfig();
cy.dataCy('data-explorer-ignore-missing-values-checkbox')
.children()
.click();
- DataLakeWidgetTableUtils.checkRows(3);
+ DataLakeWidgetTableUtils.checkAmountOfRows(3);
});
});
diff --git a/ui/cypress/tests/datalake/widgetDataConfiguration.smoke.spec.ts
b/ui/cypress/tests/datalake/widgetDataConfiguration.smoke.spec.ts
index 911cdc6b5a..1a21da1559 100644
--- a/ui/cypress/tests/datalake/widgetDataConfiguration.smoke.spec.ts
+++ b/ui/cypress/tests/datalake/widgetDataConfiguration.smoke.spec.ts
@@ -33,7 +33,7 @@ describe('Test Table View in Data Explorer', () => {
DataLakeUtils.addDataViewAndTableWidget('NewWidget', 'Persist');
// Validate that X lines are available
- DataLakeWidgetTableUtils.checkRows(10);
+ DataLakeWidgetTableUtils.checkAmountOfRows(10);
// Go back to data configuration
DataLakeUtils.selectDataConfig();
@@ -44,26 +44,26 @@ describe('Test Table View in Data Explorer', () => {
// Test number
let filterConfig = new DataLakeFilterConfig('randomnumber', '22', '=');
DataLakeUtils.dataConfigAddFilter(filterConfig);
- DataLakeWidgetTableUtils.checkRows(2);
+ DataLakeWidgetTableUtils.checkAmountOfRows(2);
DataLakeUtils.dataConfigRemoveFilter();
- DataLakeWidgetTableUtils.checkRows(10);
+ DataLakeWidgetTableUtils.checkAmountOfRows(10);
// Test number greater then
filterConfig = new DataLakeFilterConfig('randomnumber', '50', '>');
DataLakeUtils.dataConfigAddFilter(filterConfig);
- DataLakeWidgetTableUtils.checkRows(5);
+ DataLakeWidgetTableUtils.checkAmountOfRows(5);
DataLakeUtils.dataConfigRemoveFilter();
// Test number smaller then
filterConfig = new DataLakeFilterConfig('randomnumber', '50', '<');
DataLakeUtils.dataConfigAddFilter(filterConfig);
- DataLakeWidgetTableUtils.checkRows(5);
+ DataLakeWidgetTableUtils.checkAmountOfRows(5);
DataLakeUtils.dataConfigRemoveFilter();
// Test boolean
filterConfig = new DataLakeFilterConfig('randombool', 'true', '=');
DataLakeUtils.dataConfigAddFilter(filterConfig);
- DataLakeWidgetTableUtils.checkRows(6);
+ DataLakeWidgetTableUtils.checkAmountOfRows(6);
DataLakeUtils.dataConfigRemoveFilter();
// Test string & if filter is persisted correctly
@@ -71,10 +71,10 @@ describe('Test Table View in Data Explorer', () => {
DataLakeUtils.checkIfFilterIsSet(0);
DataLakeUtils.dataConfigAddFilter(filterConfig);
DataLakeUtils.checkIfFilterIsSet(1);
- DataLakeWidgetTableUtils.checkRows(4);
+ DataLakeWidgetTableUtils.checkAmountOfRows(4);
DataLakeUtils.saveAndReEditWidget('NewWidget');
DataLakeUtils.checkIfFilterIsSet(1);
- DataLakeWidgetTableUtils.checkRows(4);
+ DataLakeWidgetTableUtils.checkAmountOfRows(4);
DataLakeUtils.dataConfigRemoveFilter();
/**
@@ -89,7 +89,7 @@ describe('Test Table View in Data Explorer', () => {
cy.dataCy('data-explorer-table-row-randomtext', { timeout: 10000 })
.first({ timeout: 10000 })
.contains('c', { timeout: 10000 });
- DataLakeWidgetTableUtils.checkRows(10);
+ DataLakeWidgetTableUtils.checkAmountOfRows(10);
DataLakeUtils.saveAndReEditWidget('NewWidget');
cy.dataCy('data-explorer-group-by-randomtext')
.find('input')
diff --git a/ui/cypress/tests/datalake/widgets/table.spec.ts
b/ui/cypress/tests/datalake/widgets/table.spec.ts
index 4648835e77..62c820f7b9 100644
--- a/ui/cypress/tests/datalake/widgets/table.spec.ts
+++ b/ui/cypress/tests/datalake/widgets/table.spec.ts
@@ -17,6 +17,7 @@
*/
import { DataLakeUtils } from '../../../support/utils/datalake/DataLakeUtils';
+import { DataLakeWidgetTableUtils } from
'../../../support/utils/datalake/DataLakeWidgetTableUtils';
describe('Test Table View in Data Explorer', () => {
beforeEach('Setup Test', () => {
@@ -27,8 +28,6 @@ describe('Test Table View in Data Explorer', () => {
DataLakeUtils.addDataViewAndWidget('view', 'Persist', 'Table');
// Check if table is displayed correctly
- cy.dataCy('data-explorer-table-row-timestamp', {
- timeout: 10000,
- }).should('have.length', 10);
+ DataLakeWidgetTableUtils.checkAmountOfRows(10);
});
});
