This is an automated email from the ASF dual-hosted git repository.

zehnder pushed a commit to branch 
3460-pipeline-view-broken-after-clicking-add-template-button-twice
in repository https://gitbox.apache.org/repos/asf/streampipes.git


The following commit(s) were added to 
refs/heads/3460-pipeline-view-broken-after-clicking-add-template-button-twice 
by this push:
     new 6e9bc13939 refactor(#3139): Remove deprecated 
IParameterExtractor.selectedTreeNodesInternalNames
6e9bc13939 is described below

commit 6e9bc13939e2404905c9b1d549547e932d1b6979
Author: Philipp Zehnder <[email protected]>
AuthorDate: Tue Feb 4 14:01:11 2025 +0100

    refactor(#3139): Remove deprecated 
IParameterExtractor.selectedTreeNodesInternalNames
---
 .../pipeline-assembly-options.component.ts          |  1 -
 .../pipeline-assembly.component.ts                  | 21 +++++++++++++++++----
 2 files changed, 17 insertions(+), 5 deletions(-)

diff --git 
a/ui/src/app/editor/components/pipeline-assembly/pipeline-assembly-options/pipeline-assembly-options.component.ts
 
b/ui/src/app/editor/components/pipeline-assembly/pipeline-assembly-options/pipeline-assembly-options.component.ts
index 8169337736..9b04913888 100644
--- 
a/ui/src/app/editor/components/pipeline-assembly/pipeline-assembly-options/pipeline-assembly-options.component.ts
+++ 
b/ui/src/app/editor/components/pipeline-assembly/pipeline-assembly-options/pipeline-assembly-options.component.ts
@@ -121,7 +121,6 @@ export class PipelineAssemblyOptionsComponent {
         });
         dialogRef.afterClosed().subscribe(pipeline => {
             if (pipeline !== undefined) {
-                this.clearAssemblyEmitter.emit();
                 this.displayPipelineTemplateEmitter.emit(pipeline);
             }
         });
diff --git 
a/ui/src/app/editor/components/pipeline-assembly/pipeline-assembly.component.ts 
b/ui/src/app/editor/components/pipeline-assembly/pipeline-assembly.component.ts
index 231344d095..4e4926dcd1 100644
--- 
a/ui/src/app/editor/components/pipeline-assembly/pipeline-assembly.component.ts
+++ 
b/ui/src/app/editor/components/pipeline-assembly/pipeline-assembly.component.ts
@@ -156,14 +156,27 @@ export class PipelineAssemblyComponent implements 
AfterViewInit {
     }
 
     displayPipelineTemplate(pipeline: Pipeline) {
+        // Clears old pipeline before new elements are added
+        this.clearAssembly();
+        // TODO With destroying the jsPlumbFactoryService the input dot is 
rendered correctly
+        // However, the pipeline still does not behave as expected
+        this.jsPlumbFactoryService.destroy();
+
+        this.pipelineCanvasMetadata = new PipelineCanvasMetadata();
+        this.pipelineCanvasMetadataAvailable = false;
+
         this.originalPipeline = pipeline;
         this.rawPipelineModel = [];
+        this.rawPipelineModel = this.jsplumbService.makeRawPipeline(
+            pipeline,
+            false,
+        );
         setTimeout(() => {
-            this.rawPipelineModel = this.jsplumbService.makeRawPipeline(
-                pipeline,
-                false,
+            this.drawingAreaComponent.displayPipelineInEditor(
+                true,
+                this.pipelineCanvasMetadata,
             );
-            this.drawingAreaComponent.displayPipelineInEditor(true, undefined);
+            this.triggerCacheUpdate();
         });
     }
 }

Reply via email to