This is an automated email from the ASF dual-hosted git repository.
zehnder pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/streampipes.git
The following commit(s) were added to refs/heads/dev by this push:
new 8eca197cb4 fix: Decrease max idle time in PLC4X adapter (#3920)
8eca197cb4 is described below
commit 8eca197cb446cefb4e4f147068a2faa16550f8ef
Author: Philipp Zehnder <[email protected]>
AuthorDate: Thu Nov 13 16:42:47 2025 +0100
fix: Decrease max idle time in PLC4X adapter (#3920)
---
.../plc/adapter/generic/connection/ContinuousPlcRequestReader.java | 4 ++--
.../extensions/connectors/plc/cache/SpCachedPlcConnectionManager.java | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
a/streampipes-extensions/streampipes-connectors-plc/src/main/java/org/apache/streampipes/extensions/connectors/plc/adapter/generic/connection/ContinuousPlcRequestReader.java
b/streampipes-extensions/streampipes-connectors-plc/src/main/java/org/apache/streampipes/extensions/connectors/plc/adapter/generic/connection/ContinuousPlcRequestReader.java
index 3d04ad6312..d8f0e13916 100644
---
a/streampipes-extensions/streampipes-connectors-plc/src/main/java/org/apache/streampipes/extensions/connectors/plc/adapter/generic/connection/ContinuousPlcRequestReader.java
+++
b/streampipes-extensions/streampipes-connectors-plc/src/main/java/org/apache/streampipes/extensions/connectors/plc/adapter/generic/connection/ContinuousPlcRequestReader.java
@@ -37,7 +37,7 @@ public class ContinuousPlcRequestReader
extends OneTimePlcRequestReader implements IPullAdapter {
private static final Logger LOG =
LoggerFactory.getLogger(ContinuousPlcRequestReader.class);
- private static final int MAX_IDLE_PULLS = 300;
+ private static final int MAX_IDLE_PULLS = 500;
private final IEventCollector collector;
private int idlePullsBeforeNextAttempt = 0;
@@ -75,7 +75,7 @@ public class ContinuousPlcRequestReader
.get(5000, TimeUnit.MILLISECONDS);
processPlcReadResponse(readResponse);
} else {
- handleFailingPlcRead("Not connected");
+ LOG.error("Not connected to PLC with connection string {}",
settings.connectionString());
}
} catch (Exception e) {
handleFailingPlcRead(e.getMessage());
diff --git
a/streampipes-extensions/streampipes-connectors-plc/src/main/java/org/apache/streampipes/extensions/connectors/plc/cache/SpCachedPlcConnectionManager.java
b/streampipes-extensions/streampipes-connectors-plc/src/main/java/org/apache/streampipes/extensions/connectors/plc/cache/SpCachedPlcConnectionManager.java
index f21f008899..e3702aec10 100644
---
a/streampipes-extensions/streampipes-connectors-plc/src/main/java/org/apache/streampipes/extensions/connectors/plc/cache/SpCachedPlcConnectionManager.java
+++
b/streampipes-extensions/streampipes-connectors-plc/src/main/java/org/apache/streampipes/extensions/connectors/plc/cache/SpCachedPlcConnectionManager.java
@@ -150,7 +150,7 @@ public class SpCachedPlcConnectionManager implements
PlcConnectionManager, AutoC
this.connectionManager = connectionManager;
this.maxLeaseTime = Duration.ofSeconds(4);
this.maxWaitTime = Duration.ofSeconds(20);
- this.maxIdleTime = Duration.ofMinutes(5);
+ this.maxIdleTime = Duration.ofMinutes(1);
}
public SpCachedPlcConnectionManager build() {