This is an automated email from the ASF dual-hosted git repository. zehnder pushed a commit to branch 4139-allow-manual-upload-of-sample-event-for-adapter-schema-inference in repository https://gitbox.apache.org/repos/asf/streampipes.git
commit 60677b09a0e44719462821b26b4c1957f5d971c4 Author: Philipp Zehnder <[email protected]> AuthorDate: Fri Jan 30 17:09:51 2026 +0100 fix(#4139): Use input and output signals in configure-schema components --- .../adapter-result-preview.component.html | 12 +++++----- .../adapter-result-preview.component.ts | 12 +++++----- .../adapter-sample-preview.component.html | 16 ++++++------- .../adapter-sample-preview.component.ts | 18 +++++++------- .../adapter-script-editor.component.html | 24 +++++++++---------- .../adapter-script-editor.component.ts | 28 +++++++++++----------- 6 files changed, 55 insertions(+), 55 deletions(-) diff --git a/ui/src/app/connect/components/adapter-configuration/configure-schema/result-preview/adapter-result-preview.component.html b/ui/src/app/connect/components/adapter-configuration/configure-schema/result-preview/adapter-result-preview.component.html index 3058f8ad06..dc907b38a8 100644 --- a/ui/src/app/connect/components/adapter-configuration/configure-schema/result-preview/adapter-result-preview.component.html +++ b/ui/src/app/connect/components/adapter-configuration/configure-schema/result-preview/adapter-result-preview.component.html @@ -24,7 +24,7 @@ > <div header fxFlex="100" fxLayoutAlign="end center"> <mat-button-toggle-group - [value]="resultViewMode" + [value]="resultViewMode()" [hideSingleSelectionIndicator]="true" (valueChange)="resultViewModeChange.emit($event)" > @@ -36,7 +36,7 @@ </mat-button-toggle> </mat-button-toggle-group> </div> - @if (isRunningScript) { + @if (isRunningScript()) { <div class="m-lg"> <div fxFlex="100" fxLayoutAlign="center center" fxLayout="column"> <mat-spinner [diameter]="25"></mat-spinner> @@ -44,17 +44,17 @@ </div> </div> } @else { - @if (scriptError) { + @if (scriptError()) { <sp-exception-message class="p-xs" - [message]="scriptError" + [message]="scriptError()" [showDetails]="true" ></sp-exception-message> } @else { <sp-adapter-event-preview dataCy="configure-schema-event-preview-result" - [mode]="resultViewMode" - [value]="output" + [mode]="resultViewMode()" + [value]="output()" ></sp-adapter-event-preview> } } diff --git a/ui/src/app/connect/components/adapter-configuration/configure-schema/result-preview/adapter-result-preview.component.ts b/ui/src/app/connect/components/adapter-configuration/configure-schema/result-preview/adapter-result-preview.component.ts index 4ae85a4bae..0b953cadaa 100644 --- a/ui/src/app/connect/components/adapter-configuration/configure-schema/result-preview/adapter-result-preview.component.ts +++ b/ui/src/app/connect/components/adapter-configuration/configure-schema/result-preview/adapter-result-preview.component.ts @@ -16,7 +16,7 @@ * */ -import { Component, EventEmitter, Input, Output } from '@angular/core'; +import { Component, input, output } from '@angular/core'; import { Mode } from '../../adapter-event-preview/adapter-event-preview.component'; @Component({ @@ -25,10 +25,10 @@ import { Mode } from '../../adapter-event-preview/adapter-event-preview.componen templateUrl: './adapter-result-preview.component.html', }) export class AdapterResultPreviewComponent { - @Input() isRunningScript = false; - @Input() scriptError: any; - @Input() output: any; - @Input() resultViewMode: Mode = 'raw'; + isRunningScript = input(false); + scriptError = input<any>(); + output = input<any>(); + resultViewMode = input<Mode>('raw'); - @Output() resultViewModeChange = new EventEmitter<Mode>(); + resultViewModeChange = output<Mode>(); } diff --git a/ui/src/app/connect/components/adapter-configuration/configure-schema/sample-preview/adapter-sample-preview.component.html b/ui/src/app/connect/components/adapter-configuration/configure-schema/sample-preview/adapter-sample-preview.component.html index d693186ddb..d84955832c 100644 --- a/ui/src/app/connect/components/adapter-configuration/configure-schema/sample-preview/adapter-sample-preview.component.html +++ b/ui/src/app/connect/components/adapter-configuration/configure-schema/sample-preview/adapter-sample-preview.component.html @@ -25,7 +25,7 @@ data-cy="connect-get-new-sample-button" mat-button (click)="getSample.emit()" - [disabled]="isSampleLoading" + [disabled]="isSampleLoading()" > <mat-icon>refresh</mat-icon> <span>{{ 'Get new sample' | translate }}</span> @@ -39,7 +39,7 @@ <span>{{ 'Upload sample' | translate }}</span> </button> <mat-button-toggle-group - [value]="sourceViewMode" + [value]="sourceViewMode()" [hideSingleSelectionIndicator]="true" (valueChange)="sourceViewModeChange.emit($event)" > @@ -52,7 +52,7 @@ </mat-button-toggle-group> </div> - @if (isSampleLoading) { + @if (isSampleLoading()) { <div fxFlex="100" fxLayoutAlign="center center" @@ -63,19 +63,19 @@ <h5>{{ 'Loading' | translate }}</h5> </div> } @else { - @if (sampleErrorMessage) { + @if (sampleErrorMessage()) { <sp-exception-message - [message]="sampleErrorMessage" + [message]="sampleErrorMessage()" [showDetails]="true" ></sp-exception-message> } @else { <sp-show-field-status-infos - [fieldStatusInfos]="fieldStatusInfos" + [fieldStatusInfos]="fieldStatusInfos()" ></sp-show-field-status-infos> <sp-adapter-event-preview dataCy="configure-schema-event-preview-original" - [mode]="sourceViewMode" - [value]="input" + [mode]="sourceViewMode()" + [value]="input()" ></sp-adapter-event-preview> } } diff --git a/ui/src/app/connect/components/adapter-configuration/configure-schema/sample-preview/adapter-sample-preview.component.ts b/ui/src/app/connect/components/adapter-configuration/configure-schema/sample-preview/adapter-sample-preview.component.ts index 78714f798b..a241e94144 100644 --- a/ui/src/app/connect/components/adapter-configuration/configure-schema/sample-preview/adapter-sample-preview.component.ts +++ b/ui/src/app/connect/components/adapter-configuration/configure-schema/sample-preview/adapter-sample-preview.component.ts @@ -16,7 +16,7 @@ * */ -import { Component, EventEmitter, Input, Output } from '@angular/core'; +import { Component, input, output } from '@angular/core'; import { Mode } from '../../adapter-event-preview/adapter-event-preview.component'; @Component({ @@ -25,13 +25,13 @@ import { Mode } from '../../adapter-event-preview/adapter-event-preview.componen templateUrl: './adapter-sample-preview.component.html', }) export class AdapterSamplePreviewComponent { - @Input() isSampleLoading = false; - @Input() sampleErrorMessage: any; - @Input() fieldStatusInfos: any; - @Input() input: any; - @Input() sourceViewMode: Mode = 'raw'; + isSampleLoading = input(false); + sampleErrorMessage = input<any>(); + fieldStatusInfos = input<any>(); + input = input<any>(); + sourceViewMode = input<Mode>('raw'); - @Output() sourceViewModeChange = new EventEmitter<Mode>(); - @Output() getSample = new EventEmitter<void>(); - @Output() uploadSample = new EventEmitter<void>(); + sourceViewModeChange = output<Mode>(); + getSample = output<void>(); + uploadSample = output<void>(); } diff --git a/ui/src/app/connect/components/adapter-configuration/configure-schema/script-editor/adapter-script-editor.component.html b/ui/src/app/connect/components/adapter-configuration/configure-schema/script-editor/adapter-script-editor.component.html index 8bf4189031..ff06d7c2fa 100644 --- a/ui/src/app/connect/components/adapter-configuration/configure-schema/script-editor/adapter-script-editor.component.html +++ b/ui/src/app/connect/components/adapter-configuration/configure-schema/script-editor/adapter-script-editor.component.html @@ -19,29 +19,29 @@ [panelTitle]="'Transformation' | translate" outerMargin="20px 0px" > - @if (loadingAvailableScriptsError) { + @if (loadingAvailableScriptsError()) { <sp-alert-banner type="error" [title]="'Error loading available script languages'" - [description]="loadingAvailableScriptsError.cause" + [description]="loadingAvailableScriptsError().cause" > </sp-alert-banner> } <div header fxLayoutAlign="end center" fxFlex="100" fxLayoutGap="5px"> - @if (scriptActive) { - @if (selectedScriptMetadata) { + @if (scriptActive()) { + @if (selectedScriptMetadata()) { <button mat-button [matMenuTriggerFor]="langMenu" aria-label="Select template language" > - {{ selectedScriptMetadata.name | titlecase }} + {{ selectedScriptMetadata().name | titlecase }} <mat-icon>arrow_drop_down</mat-icon> </button> <mat-menu #langMenu="matMenu"> - @for (script of availableScripts; track script.language) { + @for (script of availableScripts(); track script.language) { <button mat-menu-item (click)="languageChange.emit(script)" @@ -49,7 +49,7 @@ <span>{{ script.name | titlecase }}</span> @if ( script.language === - selectedScriptMetadata.language + selectedScriptMetadata().language ) { <mat-icon class="ms-auto">check</mat-icon> } @@ -77,10 +77,10 @@ <mat-slide-toggle data-cy="toggle-script-active" - [ngModel]="scriptActive" + [ngModel]="scriptActive()" (ngModelChange)="toggleScriptActive.emit()" > - @if (scriptActive) { + @if (scriptActive()) { {{ 'Disable script' | translate }} } @else { {{ 'Enable script' | translate }} @@ -88,13 +88,13 @@ </mat-slide-toggle> </div> - @if (scriptActive) { + @if (scriptActive()) { <div class="code-editor-outer"> <ngx-codemirror class="code-editor" - [ngModel]="script" + [ngModel]="script()" (ngModelChange)="codeChange.emit($event)" - [options]="editorOptions" + [options]="editorOptions()" data-cy="configure-schema-script-editor" ></ngx-codemirror> </div> diff --git a/ui/src/app/connect/components/adapter-configuration/configure-schema/script-editor/adapter-script-editor.component.ts b/ui/src/app/connect/components/adapter-configuration/configure-schema/script-editor/adapter-script-editor.component.ts index bafe5f5655..a4364e9efe 100644 --- a/ui/src/app/connect/components/adapter-configuration/configure-schema/script-editor/adapter-script-editor.component.ts +++ b/ui/src/app/connect/components/adapter-configuration/configure-schema/script-editor/adapter-script-editor.component.ts @@ -16,7 +16,7 @@ * */ -import { Component, EventEmitter, Input, Output } from '@angular/core'; +import { Component, input, output } from '@angular/core'; import { ScriptMetadata } from '@streampipes/platform-services'; @Component({ @@ -25,18 +25,18 @@ import { ScriptMetadata } from '@streampipes/platform-services'; templateUrl: './adapter-script-editor.component.html', }) export class AdapterScriptEditorComponent { - @Input() scriptActive = false; - @Input() selectedScriptMetadata: ScriptMetadata; - @Input() availableScripts: ScriptMetadata[] = []; - @Input() loadingAvailableScriptsError: any; - @Input() script = ''; - @Input() editorOptions: any; + scriptActive = input(false); + selectedScriptMetadata = input<ScriptMetadata>(); + availableScripts = input<ScriptMetadata[]>([]); + loadingAvailableScriptsError = input<any>(); + script = input(''); + editorOptions = input<any>(); - @Output() codeChange = new EventEmitter<string>(); - @Output() languageChange = new EventEmitter<ScriptMetadata>(); - @Output() selectTemplate = new EventEmitter<void>(); - @Output() resetScript = new EventEmitter<void>(); - @Output() toggleScriptActive = new EventEmitter<void>(); - @Output() runScript = new EventEmitter<void>(); - @Output() createTemplate = new EventEmitter<void>(); + codeChange = output<string>(); + languageChange = output<ScriptMetadata>(); + selectTemplate = output<void>(); + resetScript = output<void>(); + toggleScriptActive = output<void>(); + runScript = output<void>(); + createTemplate = output<void>(); }
