This is an automated email from the ASF dual-hosted git repository. zehnder pushed a commit to branch 4287-migrate-angular-ui-from-constructor-injection-to-inject in repository https://gitbox.apache.org/repos/asf/streampipes.git
commit 60348e95f77112209a03d69f06129e2533915933 Author: Philipp Zehnder <[email protected]> AuthorDate: Tue Mar 24 09:57:08 2026 +0100 migrate login UI to inject() --- ui/src/app/login/components/auth-box/auth-box.component.ts | 6 +++--- ui/src/app/login/components/startup/startup.component.ts | 12 +++++------- ui/src/app/login/services/account-activation.service.ts | 8 +++----- ui/src/app/login/services/login.service.ts | 8 +++----- ui/src/app/login/services/restore-password.service.ts | 8 +++----- 5 files changed, 17 insertions(+), 25 deletions(-) diff --git a/ui/src/app/login/components/auth-box/auth-box.component.ts b/ui/src/app/login/components/auth-box/auth-box.component.ts index 38d6771670..0972210948 100644 --- a/ui/src/app/login/components/auth-box/auth-box.component.ts +++ b/ui/src/app/login/components/auth-box/auth-box.component.ts @@ -16,7 +16,7 @@ * */ -import { Component, Input } from '@angular/core'; +import { Component, Input, inject } from '@angular/core'; import { AppConstants } from '../../../services/app.constants'; import { LinkSettings } from '@streampipes/platform-services'; import { @@ -41,8 +41,8 @@ import { TranslatePipe } from '@ngx-translate/core'; ], }) export class AuthBoxComponent { + appConstants = inject(AppConstants); + @Input() linkSettings: LinkSettings; - - constructor(public appConstants: AppConstants) {} } diff --git a/ui/src/app/login/components/startup/startup.component.ts b/ui/src/app/login/components/startup/startup.component.ts index bcb5d14d3b..f167be07c4 100644 --- a/ui/src/app/login/components/startup/startup.component.ts +++ b/ui/src/app/login/components/startup/startup.component.ts @@ -17,7 +17,7 @@ */ import { AuthService } from '../../../services/auth.service'; -import { Component, OnInit } from '@angular/core'; +import { Component, OnInit, inject } from '@angular/core'; import { Router } from '@angular/router'; import { AppConstants } from '../../../services/app.constants'; import { @@ -39,17 +39,15 @@ import { MatProgressBar } from '@angular/material/progress-bar'; ], }) export class StartupComponent implements OnInit { + private authService = inject(AuthService); + private router = inject(Router); + appConstants = inject(AppConstants); + progress = 0; currentStep = 0; maxLoadingTimeInSeconds = 100; loadingIntervalInSeconds = 1; - constructor( - private authService: AuthService, - private router: Router, - public appConstants: AppConstants, - ) {} - ngOnInit() { this.checkStatus(); } diff --git a/ui/src/app/login/services/account-activation.service.ts b/ui/src/app/login/services/account-activation.service.ts index d4ae840b9e..36ab2ad40b 100644 --- a/ui/src/app/login/services/account-activation.service.ts +++ b/ui/src/app/login/services/account-activation.service.ts @@ -16,17 +16,15 @@ * */ -import { Injectable } from '@angular/core'; +import { Injectable, inject } from '@angular/core'; import { HttpClient } from '@angular/common/http'; import { PlatformServicesCommons } from '@streampipes/platform-services'; import { Observable } from 'rxjs'; @Injectable({ providedIn: 'root' }) export class AccountActivationService { - constructor( - private http: HttpClient, - private platformServicesCommons: PlatformServicesCommons, - ) {} + private http = inject(HttpClient); + private platformServicesCommons = inject(PlatformServicesCommons); activateAccount(activationToken: string): Observable<any> { return this.http.get( diff --git a/ui/src/app/login/services/login.service.ts b/ui/src/app/login/services/login.service.ts index fab0c0c03a..d5b17f1df1 100644 --- a/ui/src/app/login/services/login.service.ts +++ b/ui/src/app/login/services/login.service.ts @@ -16,7 +16,7 @@ * */ -import { Injectable } from '@angular/core'; +import { Injectable, inject } from '@angular/core'; import { HttpClient, HttpContext } from '@angular/common/http'; import { PlatformServicesCommons } from '@streampipes/platform-services'; import { Observable, shareReplay } from 'rxjs'; @@ -26,10 +26,8 @@ import { NGX_LOADING_BAR_IGNORED } from '@ngx-loading-bar/http-client'; @Injectable({ providedIn: 'root' }) export class LoginService { - constructor( - private http: HttpClient, - private platformServicesCommons: PlatformServicesCommons, - ) {} + private http = inject(HttpClient); + private platformServicesCommons = inject(PlatformServicesCommons); private settings$?: Observable<LoginModel>; diff --git a/ui/src/app/login/services/restore-password.service.ts b/ui/src/app/login/services/restore-password.service.ts index 907c65e914..9bc47c3701 100644 --- a/ui/src/app/login/services/restore-password.service.ts +++ b/ui/src/app/login/services/restore-password.service.ts @@ -16,7 +16,7 @@ * */ -import { Injectable } from '@angular/core'; +import { Injectable, inject } from '@angular/core'; import { HttpClient } from '@angular/common/http'; import { PlatformServicesCommons } from '@streampipes/platform-services'; import { Observable } from 'rxjs'; @@ -24,10 +24,8 @@ import { RegistrationModel } from '../components/register/registration.model'; @Injectable({ providedIn: 'root' }) export class RestorePasswordService { - constructor( - private http: HttpClient, - private platformServicesCommons: PlatformServicesCommons, - ) {} + private http = inject(HttpClient); + private platformServicesCommons = inject(PlatformServicesCommons); checkRecoveryCode(recoveryCode: string): Observable<any> { return this.http.get(
