This is an automated email from the ASF dual-hosted git repository. SvenO3 pushed a commit to branch 4466-add-validation-and-naming-warnings-for-property-field-names-in-adapter-schema-configuration in repository https://gitbox.apache.org/repos/asf/streampipes.git
commit 95055c6a30c2fe716a387f1360a4df905729ed9b Author: Sven Oehler <[email protected]> AuthorDate: Fri Jun 26 09:52:56 2026 +0200 Improve error message --- .../configure-schema.component.html | 56 ++++++++++++---------- .../configure-schema.component.scss | 16 +++++++ 2 files changed, 46 insertions(+), 26 deletions(-) diff --git a/ui/src/app/connect/components/adapter-configuration/configure-schema/configure-schema.component.html b/ui/src/app/connect/components/adapter-configuration/configure-schema/configure-schema.component.html index a5ac876f60..6f36ce6e17 100644 --- a/ui/src/app/connect/components/adapter-configuration/configure-schema/configure-schema.component.html +++ b/ui/src/app/connect/components/adapter-configuration/configure-schema/configure-schema.component.html @@ -20,22 +20,23 @@ <sp-alert-banner type="error" [title]="'Invalid field names' | translate" - [description]=" - 'Field names containing comma (,), double quote ("), or semicolon (;) are invalid and must be renamed before continuing.' - | translate - " data-cy="configure-schema-invalid-field-names" > - <div class="mt-md"> - @for (fieldName of invalidFieldNames(); track fieldName) { - <div - class="font-bold text-sm" - data-cy="configure-schema-invalid-field-name" - > - {{ fieldName }} - </div> - } + <div class="field-name-message text-sm"> + {{ 'Field names cannot contain' | translate }} + <span class="field-name-character">,</span>, + <span class="field-name-character">"</span>, + <span class="field-name-character">;</span>. + {{ 'Rename these fields before continuing:' | translate }} </div> + @for (fieldName of invalidFieldNames(); track fieldName) { + <div + class="font-bold text-sm" + data-cy="configure-schema-invalid-field-name" + > + {{ fieldName }} + </div> + } </sp-alert-banner> } @@ -43,22 +44,25 @@ <sp-alert-banner type="warning" [title]="'Field name recommendation' | translate" - [description]=" - 'It is recommended to use a consistent naming convention for field names without special characters, except - and _.' - | translate - " data-cy="configure-schema-warning-field-names" > - <div class="mt-md"> - @for (fieldName of warningFieldNames(); track fieldName) { - <div - class="font-bold text-sm" - data-cy="configure-schema-warning-field-name" - > - {{ fieldName }} - </div> - } + <div class="field-name-message text-sm"> + {{ + 'It is recommended to use a consistent naming convention for field names without special characters, except' + | translate + }} + <span class="field-name-character">-</span>, + <span class="field-name-character">_</span>. + {{ 'These fields should be renamed:' | translate }} </div> + @for (fieldName of warningFieldNames(); track fieldName) { + <div + class="font-bold text-sm" + data-cy="configure-schema-warning-field-name" + > + {{ fieldName }} + </div> + } </sp-alert-banner> } diff --git a/ui/src/app/connect/components/adapter-configuration/configure-schema/configure-schema.component.scss b/ui/src/app/connect/components/adapter-configuration/configure-schema/configure-schema.component.scss index 63da642e69..6dc4baf2fc 100644 --- a/ui/src/app/connect/components/adapter-configuration/configure-schema/configure-schema.component.scss +++ b/ui/src/app/connect/components/adapter-configuration/configure-schema/configure-schema.component.scss @@ -27,3 +27,19 @@ .stepper-button { margin-left: 10px; } + +.field-name-message { + margin-top: 0.25rem; + line-height: 1.4; +} + +.field-name-character { + display: inline-block; + min-width: 1.25rem; + padding: 0 0.25rem; + border-radius: 0.25rem; + background: rgba(0, 0, 0, 0.08); + font-family: monospace; + font-weight: 700; + text-align: center; +}
