This is an automated email from the ASF dual-hosted git repository.
dominikriemer pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/streampipes.git
The following commit(s) were added to refs/heads/dev by this push:
new 3f1317b591 fix(#4650): File adapter string parsing fails for quoted
delimiter (#4702)
3f1317b591 is described below
commit 3f1317b5910dbe8d8ac54d3b0838b5c6d00d018d
Author: Sven Oehler <[email protected]>
AuthorDate: Wed Jul 8 17:14:57 2026 +0200
fix(#4650): File adapter string parsing fails for quoted delimiter (#4702)
---
.../connect/adapter/parser/CsvParser.java | 1 -
.../connect/adapter/parser/CsvParserTest.java | 30 ++++++++++++++++++++++
...itAdapter.smoke.spec.ts => editAdapter.spec.ts} | 0
3 files changed, 30 insertions(+), 1 deletion(-)
diff --git
a/streampipes-extensions-management/src/main/java/org/apache/streampipes/extensions/management/connect/adapter/parser/CsvParser.java
b/streampipes-extensions-management/src/main/java/org/apache/streampipes/extensions/management/connect/adapter/parser/CsvParser.java
index 3a4da78e94..58e8eb9236 100644
---
a/streampipes-extensions-management/src/main/java/org/apache/streampipes/extensions/management/connect/adapter/parser/CsvParser.java
+++
b/streampipes-extensions-management/src/main/java/org/apache/streampipes/extensions/management/connect/adapter/parser/CsvParser.java
@@ -177,7 +177,6 @@ public class CsvParser implements IParser {
var reader = new BufferedReader(new InputStreamReader(inputStream));
CSVParser parser = new CSVParserBuilder()
.withSeparator(delimiter)
- .withIgnoreQuotations(true)
.build();
return new CSVReaderBuilder(reader)
diff --git
a/streampipes-extensions-management/src/test/java/org/apache/streampipes/extensions/management/connect/adapter/parser/CsvParserTest.java
b/streampipes-extensions-management/src/test/java/org/apache/streampipes/extensions/management/connect/adapter/parser/CsvParserTest.java
index 283bd362ea..b4cbd85609 100644
---
a/streampipes-extensions-management/src/test/java/org/apache/streampipes/extensions/management/connect/adapter/parser/CsvParserTest.java
+++
b/streampipes-extensions-management/src/test/java/org/apache/streampipes/extensions/management/connect/adapter/parser/CsvParserTest.java
@@ -76,4 +76,34 @@ public class CsvParserTest extends ParserTest {
verify(mockEventHandler, times(1)).handle(expectedEvent);
}
+ @Test
+ public void parseHeaderWithQuotedDelimiter() {
+ var event = toStream("column1,column2,\"column2,5\"\n1,2,3");
+ var mockEventHandler = mock(IParserEventHandler.class);
+
+ var parser = new CsvParser(true, ',');
+ parser.parse(event, mockEventHandler);
+
+ Map<String, Object> expectedEvent = new HashMap<>();
+ expectedEvent.put("column1", 1);
+ expectedEvent.put("column2", 2);
+ expectedEvent.put("column2,5", 3);
+ verify(mockEventHandler).handle(expectedEvent);
+ }
+
+ @Test
+ public void parseValueWithQuotedDelimiter() {
+ var event = toStream("k1,k2,k3\nv1,\"2,5\",3");
+ var mockEventHandler = mock(IParserEventHandler.class);
+
+ var parser = new CsvParser(true, ',');
+ parser.parse(event, mockEventHandler);
+
+ Map<String, Object> expectedEvent = new HashMap<>();
+ expectedEvent.put(K1, "v1");
+ expectedEvent.put(K2, "2,5");
+ expectedEvent.put("k3", 3);
+ verify(mockEventHandler).handle(expectedEvent);
+ }
+
}
diff --git a/ui/cypress/tests/connect/editAdapter.smoke.spec.ts
b/ui/cypress/tests/connect/editAdapter.spec.ts
similarity index 100%
rename from ui/cypress/tests/connect/editAdapter.smoke.spec.ts
rename to ui/cypress/tests/connect/editAdapter.spec.ts