[ 
https://issues.apache.org/jira/browse/STREAMS-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417532#comment-16417532
 ] 

ASF GitHub Bot commented on STREAMS-586:
----------------------------------------

steveblackmon commented on a change in pull request #424: resolves STREAMS-586
URL: https://github.com/apache/streams/pull/424#discussion_r177788237
 
 

 ##########
 File path: 
streams-contrib/streams-persist-neo4j/src/main/java/org/apache/streams/neo4j/CypherQueryGraphHelper.java
 ##########
 @@ -25,8 +25,11 @@
 import org.apache.streams.util.PropertyUtil;
 
 import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.SerializationFeature;
 import com.fasterxml.jackson.databind.node.ObjectNode;
 
+import com.google.common.base.Predicate;
+import com.google.common.collect.Maps;
 
 Review comment:
   these two imports aren't even used. i'll remove them

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Run docker containers supporting persist ITs one at a time
> ----------------------------------------------------------
>
>                 Key: STREAMS-586
>                 URL: https://issues.apache.org/jira/browse/STREAMS-586
>             Project: Streams
>          Issue Type: Improvement
>            Reporter: Steve Blackmon
>            Assignee: Steve Blackmon
>            Priority: Major
>
> The release process as currently documented requires the release manager to 
> start a docker container for every persist module that uses docker, all at 
> once.
> A more sensible strategy would be for each module to start it's own container 
> in pre-integration-test and stop it in post-integration-test.
> It would be nice to have a way keep the containers built during ITs running 
> once testing has concluded.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to