STREAMS-456: PR feedback
Project: http://git-wip-us.apache.org/repos/asf/incubator-streams/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-streams/commit/f597411a Tree: http://git-wip-us.apache.org/repos/asf/incubator-streams/tree/f597411a Diff: http://git-wip-us.apache.org/repos/asf/incubator-streams/diff/f597411a Branch: refs/heads/master Commit: f597411a01458a32b3c4e9fad8311de3180b4b41 Parents: 1799fbf Author: Steve Blackmon @steveblackmon <sblack...@apache.org> Authored: Wed Nov 16 02:04:04 2016 +0100 Committer: Steve Blackmon @steveblackmon <sblack...@apache.org> Committed: Wed Nov 16 02:04:04 2016 +0100 ---------------------------------------------------------------------- .../facebook/provider/page/FacebookPageDataCollector.java | 4 ++-- .../streams/facebook/provider/page/FacebookPageProvider.java | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/f597411a/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/provider/page/FacebookPageDataCollector.java ---------------------------------------------------------------------- diff --git a/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/provider/page/FacebookPageDataCollector.java b/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/provider/page/FacebookPageDataCollector.java index ca68a7e..0e88dd4 100644 --- a/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/provider/page/FacebookPageDataCollector.java +++ b/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/provider/page/FacebookPageDataCollector.java @@ -27,8 +27,8 @@ import org.apache.streams.jackson.StreamsJacksonMapper; import com.fasterxml.jackson.databind.ObjectMapper; import com.google.common.annotations.VisibleForTesting; -import com.google.common.base.Joiner; +import org.apache.commons.lang.StringUtils; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -52,7 +52,7 @@ public class FacebookPageDataCollector extends FacebookDataCollector { public FacebookPageDataCollector(BlockingQueue<StreamsDatum> queue, FacebookPageProviderConfiguration configuration) { super(configuration, queue); - fields = Joiner.on(',').join(configuration.getFields()); + fields = StringUtils.join(configuration.getFields(), ','); } @Override http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/f597411a/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/provider/page/FacebookPageProvider.java ---------------------------------------------------------------------- diff --git a/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/provider/page/FacebookPageProvider.java b/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/provider/page/FacebookPageProvider.java index cd74927..d11a486 100644 --- a/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/provider/page/FacebookPageProvider.java +++ b/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/provider/page/FacebookPageProvider.java @@ -31,7 +31,6 @@ import org.apache.streams.jackson.StreamsJacksonMapper; import com.fasterxml.jackson.core.JsonProcessingException; import com.fasterxml.jackson.databind.ObjectMapper; import com.google.common.annotations.VisibleForTesting; -import com.google.common.base.Joiner; import com.google.common.base.Preconditions; import com.google.common.util.concurrent.Uninterruptibles; import com.typesafe.config.Config;
