Github user smarthi commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/348#discussion_r95082300
  
    --- Diff: 
streams-util/src/main/java/org/apache/streams/util/PropertyUtil.java ---
    @@ -98,22 +102,24 @@ public static ObjectNode 
unflattenObjectNode(ObjectNode flatObject, char seperat
         while (iter.hasNext()) {
           Map.Entry<String, JsonNode> item = iter.next();
           String fullKey = item.getKey();
    -      if ( !fullKey.contains(Character.valueOf(seperator).toString())) {
    +      if( !fullKey.contains(Character.valueOf(seperator).toString())) {
             root.put(item.getKey(), item.getValue());
           } else {
             ObjectNode currentNode = root;
    -        List<String> keyParts = new ArrayList<>();
    +        List<String> keyParts = Lists.newArrayList();
    --- End diff --
    
    any reason for switching back to using Guava here, don't see the benefit


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to