[ 
https://issues.apache.org/jira/browse/STREAMS-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15809582#comment-15809582
 ] 

ASF GitHub Bot commented on STREAMS-344:
----------------------------------------

Github user smarthi commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/348#discussion_r95082300
  
    --- Diff: 
streams-util/src/main/java/org/apache/streams/util/PropertyUtil.java ---
    @@ -98,22 +102,24 @@ public static ObjectNode 
unflattenObjectNode(ObjectNode flatObject, char seperat
         while (iter.hasNext()) {
           Map.Entry<String, JsonNode> item = iter.next();
           String fullKey = item.getKey();
    -      if ( !fullKey.contains(Character.valueOf(seperator).toString())) {
    +      if( !fullKey.contains(Character.valueOf(seperator).toString())) {
             root.put(item.getKey(), item.getValue());
           } else {
             ObjectNode currentNode = root;
    -        List<String> keyParts = new ArrayList<>();
    +        List<String> keyParts = Lists.newArrayList();
    --- End diff --
    
    any reason for switching back to using Guava here, don't see the benefit


> Support binary protocol in streams-persist-graph
> ------------------------------------------------
>
>                 Key: STREAMS-344
>                 URL: https://issues.apache.org/jira/browse/STREAMS-344
>             Project: Streams
>          Issue Type: Improvement
>          Components: Persist
>            Reporter: Steve Blackmon
>            Assignee: Steve Blackmon
>             Fix For: 0.5
>
>
> Support batch writes in GraphHttpPersistWriter.
> Using a separate HTTP Post for every datum is inefficient.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to