Github user jfrazee commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/350#discussion_r95895146
  
    --- Diff: pom.xml ---
    @@ -235,7 +888,7 @@
                                 <id>validate</id>
                                 <phase>validate</phase>
                                 <configuration>
    -                                
<configLocation>http://streams.incubator.apache.org/site/${project.version}/streams-master/streams-java-checkstyle.xml</configLocation>
    +                                
<configLocation>http://streams.incubator.apache.org/site/latest/streams-master/streams-java-checkstyle.xml</configLocation>
    --- End diff --
    
    Two problems with this I think. First, it references streams-master. Is the 
site still being published to streams-master (I'll probably answer that to 
myself in a minute). Second, suppose we evolve the check style forward, old 
existing Apache releases could be invalid against it. That seems wrong as if it 
checks out ok at time of release, it always should (or at least until we hit a 
1.x or release that makes the old stuff out of maintenance).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to