liuxunorg commented on a change in pull request #249: SUBMARINE-455. Support 
find/patch/delete job in submarine-server REST
URL: https://github.com/apache/submarine/pull/249#discussion_r398275780
 
 

 ##########
 File path: 
submarine-server/server-core/src/test/java/org/apache/submarine/server/rest/JobManagerRestApiTest.java
 ##########
 @@ -156,8 +149,7 @@ public void testDeleteJobById() throws IOException {
 
     Gson gson = new Gson();
     JsonResponse jsonResponse = gson.fromJson(requestBody, JsonResponse.class);
-    assertEquals("Response code should be 200 ",
-        Response.Status.OK.getStatusCode(), jsonResponse.getCode());
+    assertEquals(Response.Status.NOT_FOUND.getStatusCode(), 
jsonResponse.getCode());
 
 Review comment:
   `testDeleteJobById()` needs to be able to real delete the JOB  instead of 
`NOT_FOUND` JOB, otherwise this test case is meaningless.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to