ByronHsu commented on a change in pull request #464:
URL: https://github.com/apache/submarine/pull/464#discussion_r531452594
##########
File path: dev-support/pysubmarine/gen-sdk.sh
##########
@@ -29,6 +29,7 @@ submarine_dist_exists=$(find -L
"${SUBMARINE_PROJECT_PATH}/submarine-dist/target
if [[ -z "${submarine_dist_exists}" ]]; then
cd "${SUBMARINE_PROJECT_PATH}"
mvn clean package -DskipTests
+ cd "$FWDIR" # go back to FWDIR after packaging
Review comment:
If lacking this command, there will be an error. To be more specific, in
line 52, we cannot find swagger_config.json because we are in root dir of
submarine but swagger_config.json is in ./dev-support
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
