charlie0220 commented on a change in pull request #481:
URL: https://github.com/apache/submarine/pull/481#discussion_r557008548



##########
File path: 
submarine-test/test-k8s/src/test/java/org/apache/submarine/rest/NotebookRestApiIT.java
##########
@@ -188,6 +189,7 @@ public void testListNotebooksWithUserId() throws Exception {
     Assert.assertEquals(ENV_NAME, 
getEnvironment.getEnvironmentSpec().getName());
 
     // create notebook instances
+    Thread.sleep(15000);

Review comment:
       In this test we use different ways to create notebook with the same name 
and delete it in very short time, but persistent volume (pv) can not be deleted 
quickly. When previous pv haven't been deleted completely and we create new pv 
with the same name, the error will occur, so I choose to add Thread.sleep. I 
will add some comments in the file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to