pingsutw commented on a change in pull request #492:
URL: https://github.com/apache/submarine/pull/492#discussion_r558870725
##########
File path:
submarine-workbench/workbench-web/src/app/pages/workbench/experiment/experiment-home/experiment-home.component.html
##########
@@ -24,11 +24,18 @@
<label nz-radio-button nzValue="Own">Owned By Me</label>
<label nz-radio-button nzValue="Access">Accessible By Me</label>
</nz-radio-group>
- <nz-input-group
- nzSearch
- style="width: 300px; margin-top: 15px; margin-left: 10px; margin-right:
5px"
- [nzAddOnAfter]="suffixIconButton"
+ <a
+ nz-button
+ nzType="primary"
+ style="margin: 0px 4px 0px 4px"
+ [nzLoading]="isTensorboardLoading"
+ [href]="tensorboardUrl"
>
+ <i nz-icon nzType="area-chart"></i>
+ Tensorboard
Review comment:
```suggestion
TensorBoard
```
##########
File path:
submarine-workbench/workbench-web/src/app/pages/workbench/experiment/experiment-home/experiment-home.component.ts
##########
@@ -114,4 +121,28 @@ export class ExperimentHomeComponent implements OnInit {
onInitModal(obj) {
this.form.initModal(obj.initMode, obj.initFormType, obj.id, obj.spec);
}
+
+ getTensorboardInfo(period: number, due: number) {
Review comment:
it would be better to use `timeout` instead of `due`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
