pingsutw commented on a change in pull request #497: URL: https://github.com/apache/submarine/pull/497#discussion_r565399568
########## File path: dev-support/docker-images/jupyter/Dockerfile ########## @@ -92,12 +92,14 @@ RUN wget --quiet https://repo.continuum.io/miniconda/Miniconda3-py37_${MINICONDA rm -rf /home/$NB_USER/.cache/yarn # Install latest sumbarine python sdk and notebook -RUN pip install notebook==6.1.3 && \ - git clone https://github.com/apache/submarine && \ - pip install submarine/submarine-sdk/pysubmarine && \ - cp submarine/submarine-sdk/pysubmarine/example/submarine_experiment_sdk.ipynb $HOME && \ - cp -r submarine/submarine-sdk/pysubmarine/example/{data,deepfm_example.ipynb,deepfm.json} $HOME && \ - rm submarine -rf +RUN git clone https://github.com/apache/submarine && \ +pip install submarine/submarine-sdk/pysubmarine && \ +conda install nodejs && \ +conda install -c conda-forge jupyterlab jupyterlab-git && \ +jupyter lab build && \ +cp submarine/submarine-sdk/pysubmarine/example/submarine_experiment_sdk.ipynb $HOME && \ +cp -r submarine/submarine-sdk/pysubmarine/example/{data,deepfm_example.ipynb,deepfm.json} $HOME && \ +rm submarine -rf Review comment: ```suggestion pip install submarine/submarine-sdk/pysubmarine && \ conda install nodejs && \ conda install -c conda-forge jupyterlab jupyterlab-git && \ jupyter lab build && \ cp submarine/submarine-sdk/pysubmarine/example/submarine_experiment_sdk.ipynb $HOME && \ cp -r submarine/submarine-sdk/pysubmarine/example/{data,deepfm_example.ipynb,deepfm.json} $HOME && \ rm submarine -rfpip install submarine/submarine-sdk/pysubmarine && \ conda install nodejs && \ conda install -c conda-forge jupyterlab jupyterlab-git && \ jupyter lab build && \ cp submarine/submarine-sdk/pysubmarine/example/submarine_experiment_sdk.ipynb $HOME && \ cp -r submarine/submarine-sdk/pysubmarine/example/{data,deepfm_example.ipynb,deepfm.json} $HOME && \ rm submarine -rf ``` ########## File path: dev-support/docker-images/jupyter/Dockerfile ########## @@ -92,12 +92,14 @@ RUN wget --quiet https://repo.continuum.io/miniconda/Miniconda3-py37_${MINICONDA rm -rf /home/$NB_USER/.cache/yarn # Install latest sumbarine python sdk and notebook -RUN pip install notebook==6.1.3 && \ - git clone https://github.com/apache/submarine && \ - pip install submarine/submarine-sdk/pysubmarine && \ - cp submarine/submarine-sdk/pysubmarine/example/submarine_experiment_sdk.ipynb $HOME && \ - cp -r submarine/submarine-sdk/pysubmarine/example/{data,deepfm_example.ipynb,deepfm.json} $HOME && \ - rm submarine -rf +RUN git clone https://github.com/apache/submarine && \ +pip install submarine/submarine-sdk/pysubmarine && \ +conda install nodejs && \ +conda install -c conda-forge jupyterlab jupyterlab-git && \ +jupyter lab build && \ +cp submarine/submarine-sdk/pysubmarine/example/submarine_experiment_sdk.ipynb $HOME && \ +cp -r submarine/submarine-sdk/pysubmarine/example/{data,deepfm_example.ipynb,deepfm.json} $HOME && \ +rm submarine -rf Review comment: Btw, Why do we need to install `nodejs`? Are we gonna use it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
