kevin85421 opened a new pull request #530:
URL: https://github.com/apache/submarine/pull/530


   ### What is this PR for?
   The document of submarine-operator is outdated, and thus we cannot launch 
the submarine operator with this document. 
   For example, 
   
   (1) (submarine-operator.md) Kind v0.6.0 deprecates `kind get kubeconfig-path`
   (2) (manifests/submarine-operator/deployment.yaml) `selector` field is 
necessary.
   (3) (manifests/submarine-operator/deployment.yaml) Now, deployment is 
`apiVersion: apps/v1` rather than `extensions/v1beta1`.
   (4) The .yaml files in `manifests/` are very different with the files in 
`helm-charts/`. Therefore, some errors will occur. For instance, there is no 
`configMap` in  `helm-charts/submarine/templates/submarine-server.yaml`, but a 
`configMap` is defined in `manifests/submarine-cluster/submarine-server.yaml`. 
   
   Hence, we need to update this document, and we should refactor this 
component next.
   
   ### What type of PR is it?
   [Documentation]
   
   ### Todos
   * Refactor submarine-operator
   
   ### What is the Jira issue?
   
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-759?filter=allopenissues
   
   ### How should this be tested?
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to