pingsutw commented on a change in pull request #540:
URL: https://github.com/apache/submarine/pull/540#discussion_r606681316
##########
File path:
submarine-server/server-core/src/test/java/org/apache/submarine/server/rest/EnvironmentRestApiTest.java
##########
@@ -79,7 +82,7 @@ public void createAndUpdateEnvironment() {
KernelSpec kernelSpec = new KernelSpec();
kernelSpec.setName(kernelName);
kernelSpec.setChannels(kernelChannels);
- kernelSpec.setDependencies(kernelDependencies);
+ kernelSpec.setCondaDependencies(kernelCondaDependencies);
Review comment:
We should also add `kernelPipDependencies` in the`kernelSpec`
##########
File path:
submarine-server/server-core/src/test/java/org/apache/submarine/server/rest/ExperimentRestApiTest.java
##########
@@ -110,7 +110,7 @@ public void testCreateExperiment() {
actualExperiment.setExperimentId(experimentId);
kernelSpec.setName(kernelSpecName);
kernelSpec.setChannels(kernelChannels);
- kernelSpec.setDependencies(kernelDependencies);
+ kernelSpec.setCondaDependencies(kernelDependencies);
Review comment:
```suggestion
kernelSpec.setCondaDependencies(kernelCondaDependencies);
```
##########
File path:
submarine-server/server-core/src/test/java/org/apache/submarine/server/rest/ExperimentRestApiTest.java
##########
@@ -110,7 +110,7 @@ public void testCreateExperiment() {
actualExperiment.setExperimentId(experimentId);
kernelSpec.setName(kernelSpecName);
kernelSpec.setChannels(kernelChannels);
- kernelSpec.setDependencies(kernelDependencies);
+ kernelSpec.setCondaDependencies(kernelDependencies);
Review comment:
We should also add `kernelPipDependencies` in the `kernelSpec`
##########
File path:
submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/parser/NotebookSpecParser.java
##########
@@ -107,16 +107,25 @@ private static V1PodTemplateSpec
parseTemplateSpec(NotebookSpec notebookSpec) {
StringBuffer installCommand = new StringBuffer();
installCommand.append(condaVersionValidationCommand);
- // If dependencies isn't empty
- if (kernel.getDependencies().size() > 0) {
+ // If conda dependencies isn't empty
+ if (kernel.getCondaDependencies().size() > 0) {
installCommand.append(" && conda install -y");
for (String channel : kernel.getChannels()) {
installCommand.append(" ");
installCommand.append("-c");
installCommand.append(" ");
installCommand.append(channel);
}
- for (String dependency : kernel.getDependencies()) {
+ for (String dependency : kernel.getCondaDependencies()) {
+ installCommand.append(" ");
+ installCommand.append(dependency);
+ }
+ }
+
+ // If conda dependencies isn't empty
Review comment:
```suggestion
// If pip dependencies isn't empty
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
