cxorm commented on a change in pull request #552:
URL: https://github.com/apache/submarine/pull/552#discussion_r612098316
##########
File path:
submarine-client/src/main/java/org/apache/submarine/client/cli/param/runjob/RunJobParameters.java
##########
@@ -347,7 +347,7 @@ public boolean isDistributed() {
@VisibleForTesting
public static class UnderscoreConverterPropertyUtils extends PropertyUtils {
@Override
- public Property getProperty(Class<? extends Object> type, String name)
throws IntrospectionException {
Review comment:
> We need to be careful about binary compatibility for public APIs, for
they could throw NoSuchMethodException during runtime, or cause compilation
error during compile time.
Thanks @jojochuang for the catch, I agree to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
