kevin85421 commented on a change in pull request #602:
URL: https://github.com/apache/submarine/pull/602#discussion_r650409365
##########
File path:
submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/K8sSubmitter.java
##########
@@ -268,8 +268,8 @@ public TensorboardInfo getTensorboardInfo() throws
SubmarineRuntimeException {
final String name = "submarine-tensorboard";
final String ingressRouteName = "submarine-tensorboard-ingressroute";
String namespace = "default";
- if (System.getenv(ENV_NAMESPACE) != null) {
- namespace = System.getenv(ENV_NAMESPACE);
+ if (System.getProperty(ENV_NAMESPACE) != null) {
+ namespace = System.getProperty(ENV_NAMESPACE);
Review comment:
getenv
##########
File path:
submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/K8sSubmitter.java
##########
@@ -268,8 +268,8 @@ public TensorboardInfo getTensorboardInfo() throws
SubmarineRuntimeException {
final String name = "submarine-tensorboard";
final String ingressRouteName = "submarine-tensorboard-ingressroute";
String namespace = "default";
- if (System.getenv(ENV_NAMESPACE) != null) {
- namespace = System.getenv(ENV_NAMESPACE);
+ if (System.getProperty(ENV_NAMESPACE) != null) {
Review comment:
getenv
##########
File path:
submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/K8sSubmitter.java
##########
@@ -412,16 +427,22 @@ public Notebook deleteNotebook(NotebookSpec spec) throws
SubmarineRuntimeExcepti
final String name = spec.getMeta().getName();
final String pvName = NotebookUtils.PV_PREFIX + name;
final String pvcName = NotebookUtils.PVC_PREFIX + name;
+ String namespace = "default";
+
+ if (System.getProperty(ENV_NAMESPACE) != null) {
Review comment:
getenv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
