[GitHub] [submarine] kevin85421 opened a new pull request #630: SUBMARINE-886. Underscore character is invalid for experiment name

[GitBox]

kevin85421 opened a new pull request #630:
URL: https://github.com/apache/submarine/pull/630


   ### What is this PR for?
   * Underscore character is invalid for experiment name, and it will cause 
Kubernetes Java API to throw an exception "io.kubernetes.client.ApiException" 
with the error message "Unprocessable Entity" as shown in the attachment 
figure. In addition, no POD related to the experiment will be created, and 
users cannot get any error notification from the workbench.
   <img width="915" alt="截圖 2021-07-01 下午12 25 43" 
src="https://user-images.githubusercontent.com/20109646/124086289-7c8b3180-da83-11eb-9932-9cc7bb15bbc4.png";>
   
   * In this PR, the valid characters for experiment name only include "a-z", 
"A-Z", "0-9", and "-". Hence, the ApiException can be avoided.
   
   ### What type of PR is it?
   [Bug Fix]
   
   ### Todos
   
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-886
   
   ### How should this be tested?
   * Workbench -> New Experiment -> Define your experiment -> Enter experiment 
name
   
   ### Screenshots (if appropriate)
   <img width="997" alt="截圖 2021-07-01 下午3 44 00" 
src="https://user-images.githubusercontent.com/20109646/124087097-47331380-da84-11eb-96e8-a316edf87285.png";>
   <img width="994" alt="截圖 2021-07-01 下午3 44 16" 
src="https://user-images.githubusercontent.com/20109646/124087103-48fcd700-da84-11eb-9f93-48feda1ca600.png";>
   <img width="994" alt="截圖 2021-07-01 下午3 45 04" 
src="https://user-images.githubusercontent.com/20109646/124087119-4bf7c780-da84-11eb-8a4b-809fc2cd4111.png";>
   <img width="986" alt="截圖 2021-07-01 下午3 44 40" 
src="https://user-images.githubusercontent.com/20109646/124087123-4dc18b00-da84-11eb-8d38-d7abd0e242c5.png";>
   
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@submarine.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org