jiwq commented on a change in pull request #622:
URL: https://github.com/apache/submarine/pull/622#discussion_r668397755
##########
File path:
submarine-server/server-core/src/main/java/org/apache/submarine/server/experiment/ExperimentManager.java
##########
@@ -108,8 +108,10 @@ public Experiment createExperiment(ExperimentSpec spec)
throws SubmarineRuntimeE
spec.getMeta().getEnvVars().put(RestConstants.SUBMARINE_TRACKING_URI, url);
spec.getMeta().getEnvVars().put(RestConstants.LOG_DIR_KEY,
RestConstants.LOG_DIR_VALUE);
- String lowerName = spec.getMeta().getName().toLowerCase();
+ String lowerName = spec.getMeta().getName().toLowerCase();
spec.getMeta().setName(lowerName);
+ spec.getMeta().setExpID(id.toString().replaceAll("_", "-"));
Review comment:
+1 After discussed offline. Thanks @kevin85421 for the future design, I
expected the refactor of experiment feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
