pingsutw commented on a change in pull request #655:
URL: https://github.com/apache/submarine/pull/655#discussion_r669506548
##########
File path:
submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/K8sSubmitter.java
##########
@@ -683,6 +703,30 @@ private IngressRouteSpec parseIngressRouteSpec(String
namespace, String name) {
return spec;
}
+ private void rollbackCreationNotebook(String pvName) {
+ try {
+ deletePersistentVolume(pvName);
+ } catch (ApiException e) {
+ LOG.error("K8s submitter: delete persistent volume failed by {}, may
cause some dirty data",
+ e.getMessage());
+ }
+ }
+
+ private void rollbackCreationNotebook(String pvName, String pvcName, String
namespace) {
Review comment:
```suggestion
private void deletePersistentVolumeClaim(String pvName, String pvcName,
String namespace) {
```
##########
File path:
submarine-server/server-submitter/submitter-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/K8sSubmitter.java
##########
@@ -683,6 +703,30 @@ private IngressRouteSpec parseIngressRouteSpec(String
namespace, String name) {
return spec;
}
+ private void rollbackCreationNotebook(String pvName) {
Review comment:
I think the function name is a little confusing. Maybe we will have
other services that need rollback creation in the future. So I think it's
better to change to below.
```suggestion
private void deletePersistentVolume(String pvName) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
