noidname01 opened a new pull request #692:
URL: https://github.com/apache/submarine/pull/692


   ### What is this PR for?
   
   [Former PR](https://issues.apache.org/jira/browse/SUBMARINE-886) has some 
edge case.
   Like:
   * \-
   * --invalid
   
   Valid cases are like:
   * valid-one
   * valid1
   
   So I change the pattern for validating experiment name to filter these cases.
   And I also add this pattern to experiment name of predefine template.
   
   ### What type of PR is it?
   [Bug Fix]
   
   ### Todos
   
   None
   
   ### What is the Jira issue?
   
   https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-955
   
   ### How should this be tested?
   
   Open the workbench and type invalid experiment name.
   
   ### Screenshots (if appropriate)
   
   invalid name on custom experiment
   ![2021-08-01 14-47-13 
的螢幕擷圖](https://user-images.githubusercontent.com/55401762/127762058-e73ad41d-546b-4b45-960a-5d15b646d2cc.png)
   invalid name on predefine experiment
   ![2021-08-01 14-47-34 
的螢幕擷圖](https://user-images.githubusercontent.com/55401762/127762063-1510f983-a388-4472-89c4-7b7451cbaab5.png)
   valid name on custom experiment
   ![2021-08-01 14-48-07 
的螢幕擷圖](https://user-images.githubusercontent.com/55401762/127762066-2816e348-3202-43ce-b541-41ab4c85ca1b.png)
   valid name on predefine experiment
   ![2021-08-01 14-47-52 
的螢幕擷圖](https://user-images.githubusercontent.com/55401762/127762067-eda0d8c6-cb71-426c-a8af-6f446e9bffa8.png)
   
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to