KUAN-HSUN-LI opened a new pull request #736:
URL: https://github.com/apache/submarine/pull/736


   ### What is this PR for?
   Currently, submarine python code format doesn't work well.
   1. Replace `yapf` with `black`
   2. Upgrade `isort`
   3. Use `flake8` linter
   4. Format the code in dev-support, submarine-sdk and website
   5. Only check lint in dev-support, submarine-sdk since python code in 
website has its' style. (import not at top of file)
   6. Update the SDK development guide
   
   ### What type of PR is it?
   [Improvement]
   
   ### Todos
   
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-1008
   
   ### How should this be tested?
   I have updated the ci in GitHub Actions.
   
   ### Screenshots (if appropriate)
   Original `dev-support/style-check/python/lint.sh` result. I have fixed all 
of the errors in the below images
   ![螢幕擷取畫面 2021-09-06 
094648](https://user-images.githubusercontent.com/38066413/132158081-bdcfe866-08b6-44fa-a5d2-23f9cec3aaa9.png)
   
![image](https://user-images.githubusercontent.com/38066413/132158044-ae18abed-469f-4cf9-a866-b0144a8f2698.png)
   
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? Yes
   * Does this need new documentation? Yes
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to